'Review Request 122135: Add ecm_add_app_icon function.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Review Request 122135: Add ecm_add_app_icon function.
From:       "Alex Merry" <alex.merry () kde ! org>
Date:       2015-01-18 22:32:45
Message-ID: 20150118223245.28748.55755 () probe ! kde ! org
[Download RAW message or body]

--===============6287195681389624295==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122135/
-----------------------------------------------------------

Review request for Extra Cmake Modules, Ralf Habacker and Jeremy Whiting.

Repository: extra-cmake-modules

Description
-------

This adds an application icon to an executable from PNG files for
Windows and Mac OS X. Unlike the similar kde4_add_app_icon macro from
kdelibs, this requires icons to be explicitly listed as arguments
(meaning CMake can tell when ones are added or deleted and reconfigure
as appropriate), and it works with Matthias Benkmann's png2ico tool, as
well as the KDE-Win tool of the same name.

Currently missing unit tests. Also completely untested (except that
`make test` runs on Linux, so there are no obvious syntax errors).

CHANGELOG: Add ECMAddAppIcon module to add icons to executable targets
on Windows and Mac OS X.

Diffs
-----

  docs/find-module/FindPng2Ico.rst PRE-CREATION 
  docs/module/ECMAddAppIcon.rst PRE-CREATION 
  find-modules/FindPng2Ico.cmake PRE-CREATION 
  modules/ECMAddAppIcon.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122135/diff/

Testing
-------

`make test` passes, which just provides a very basic check for syntax errors.

Thanks,

Alex Merry

--===============6287195681389624295==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122135/">https://git.reviewboard.kde.org/r/122135/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Extra Cmake Modules, Ralf Habacker and Jeremy Whiting.</div>
<div>By Alex Merry.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This adds an application icon to an executable from \
PNG files for Windows and Mac OS X. Unlike the similar kde4_add_app_icon macro from
kdelibs, this requires icons to be explicitly listed as arguments
(meaning CMake can tell when ones are added or deleted and reconfigure
as appropriate), and it works with Matthias Benkmann's png2ico tool, as
well as the KDE-Win tool of the same name.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Currently missing unit tests. Also completely untested \
(except that `make test` runs on Linux, so there are no obvious syntax errors).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">CHANGELOG: Add ECMAddAppIcon module to add icons to \
executable targets on Windows and Mac OS X.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">make \
test</code> passes, which just provides a very basic check for syntax \
errors.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>docs/find-module/FindPng2Ico.rst <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>docs/module/ECMAddAppIcon.rst <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>find-modules/FindPng2Ico.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>modules/ECMAddAppIcon.cmake <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122135/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6287195681389624295==--

_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

[prev in list] [next in list] [prev in thread] [next in thread] 