[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 121448: Introduce ECMAddAppIcon.
From: "Ralf Habacker" <ralf.habacker () freenet ! de>
Date: 2015-01-16 12:11:25
Message-ID: 20150116121125.19346.46529 () probe ! kde ! org
[Download RAW message or body]
--===============5652340160981345756==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dez. 12, 2014, 3:08 nachm., Alex Merry wrote:
> > modules/ECMAddAppIcon.cmake, line 15
> > <https://git.reviewboard.kde.org/r/121448/diff/1/?file=332663#file332663line15>
> >
> > Would this actually work? The code looks to me like pattern_rx would just be the \
> > filename again, so fn would be empty, and the icon would never be appended to \
> > _list.
>
> Ralf Habacker wrote:
> The doc in the origin cmake macro file seems to be out of sync with the official \
> doc located in FindKDE4Internals.cmake, which is:
> ---------------------------------------------------
> # adds an application icon to target source list.
> # Make sure you have a 128x128 icon, or the icon won't display on Mac OS X.
> # Mac OSX notes : the application icon is added to a Mac OS X bundle so that \
> Finder and friends show the right thing. # Win32 notes: the application icon(s) \
> are compiled into the application # There is some workaround in \
> kde4_add_kdeinit_executable to make it possible for those applications as well. # \
> Parameters: # SRCS_VAR - specifies the list of source files
> # pattern - regular expression for searching application icons
> # Example: KDE4_ADD_APP_ICON( myapp_SOURCES "pics/cr*-myapp.png")
> # Example: KDE4_ADD_APP_ICON( myapp_KDEINIT_SRCS "icons/oxygen/*/apps/myapp.png")
> ---------------------------------------------------
>
> normal file mode is not documentated and does not work
>
> Alex Merry wrote:
> I would still much prefer an API to match ecm_add_icons, as I noted at the start of \
> this review. Would you be willing to do that? If not, I can probably find some time \
> over Christmas to look at it.
> Ralf Habacker wrote:
> Just one question: As it turns out that the macro used in KDE4 only supports a \
> "simple pattern" style and no single files, what is different or has been extended \
> with KDE5 to require this now ?
> Alex Merry wrote:
> Best CMake practices include listing all source files in the CMakeLists.txt file, \
> rather than globbing them. That way, CMake knows when a file has been added (or \
> removed), because the CMakeLists.txt file will change, and so it will automatically \
> reconfigure when you run `make`. The icon installation function (`ecm_add_icons`) \
> was changed to support and encourage that approach, and I think this function \
> should also change to match it.
> Additionally, I would like consistency between interfaces. Having ecm_add_app_icon \
> behave completely differently to ecm_add_icons just makes things that much harder \
> for users of e-c-m. They should use the same file naming scheme (or compatible \
> schemes, at least), and similar arguments, in so far as they need similar \
> information.
> I'll admit it makes porting a little harder, but it should be possible to create a \
> porting script without too much difficulty.
> Jeremy Whiting wrote:
> Ralf any updates on this patch?
@Alex, you wrote
> The icon installation function (ecm_add_icons)
you are refering to ecm_install_icons ?
> was changed to support and encourage that approach, and I think this function \
> should also change to match it.
What could be matched ? As far as I can see only the ICONS parameter, all other \
parameter do not match by design. :-(
Merging the ICONS parameter with recent ecm_add_app_icon parameter list will have the \
following syntax:
1. ecm_add_app_icon(<source_var> ICONS <icon> [<icon> [...]])
the additional mentioned syntax forms are not supported by ecm_install_icons so we \
are free to choose what we like.
According to http://www.cmake.org/cmake/help/v3.0/command/install.html the mentioned \
term 'PATTERN' only supports '*' at the end of files and therefore does not fit into \
the recent implementation.
So the term 'GLOB' which is defined in the cmake file command \
http://www.cmake.org/cmake/help/v3.0/command/file.html remains and fit into what is \
implemented in the patch
2. ecm_add_app_icons(<source_var> GLOB <icon-glob-expression>) [1]
and
3. ecm_add_app_icon(<source_var< <icon-glob-expression>) [1]
because ecm_install_icons also have a compatibility mode to support old style \
parameter list:
" From https://projects.kde.org/projects/kdesupport/extra-cmake-modules/repository/revisions/master/entry/modules/ECMInstallIcons.cmake
An old form of arguments will also be accepted::
# ecm_install_icons(<icon_install_dir> [<l10n_code>])
"
syntax 3 is what is already implemented by the recent patch.
Can we agree ?
@Jeremey:
1. Syntax 3 is already implemented and need only a few spelling fixed before commit.
2. Currently I do not have any access to a Mac/OSX development machine, so I can only \
cover the windows part. Is there anyone having access to a Mac OSX development \
machine ? 3. If not I would remove the Mac OSX support for now.
- Ralf
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121448/#review71863
-----------------------------------------------------------
On Dez. 15, 2014, 9:01 vorm., Ralf Habacker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121448/
> -----------------------------------------------------------
>
> (Updated Dez. 15, 2014, 9:01 vorm.)
>
>
> Review request for Extra Cmake Modules, KDE Frameworks and Laurent Navet.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> This module, which has been migrated from the related KDE4 macto kde4_app_app_icon,
> supports platform specific application icon for Windows and Mac OSX.
>
> On Windows this function depends on the external tool png2ico, which is
> provided by the kdewin-tools binary package. Sources are available at
> https://projects.kde.org/projects/kdesupport/kdewin.
>
>
> Diffs
> -----
>
> modules/ECMAddAppIcon.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/121448/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> ECMAddAppIcon.cmake
> https://git.reviewboard.kde.org/media/uploaded/files/2014/12/12/a05ee2b5-64e3-4e44-ae34-4e1b7110e5f1__ECMAddAppIcon.cmake
> ECMAddAppIcon.cmake
> https://git.reviewboard.kde.org/media/uploaded/files/2014/12/15/8b3e226f-a70b-4998-983a-813730a436bf__ECMAddAppIcon.cmake
> ECMAddAppIcon.cmake
> https://git.reviewboard.kde.org/media/uploaded/files/2014/12/15/8433995f-b88f-426d-af54-46aba635ae1e__ECMAddAppIcon.cmake
>
>
> Thanks,
>
> Ralf Habacker
>
>
--===============5652340160981345756==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121448/">https://git.reviewboard.kde.org/r/121448/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Dezember 12th, 2014, 3:08 nachm. CET, <b>Alex \
Merry</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/121448/diff/1/?file=332663#file332663line15" \
style="color: black; font-weight: bold; text-decoration: \
underline;">modules/ECMAddAppIcon.cmake</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">15</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="c"># example: ecm_app_app_icon(myapp_SRCS \
"pics/cr16-myapp.png;pics/cr32-myapp.png")</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Would \
this actually work? The code looks to me like pattern_rx would just be the filename \
again, so fn would be empty, and the icon would never be appended to _list.</p></pre> \
</blockquote>
<p>On Dezember 15th, 2014, 8:39 vorm. CET, <b>Ralf Habacker</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
doc in the origin cmake macro file seems to be out of sync with the official doc \
located in FindKDE4Internals.cmake, which is: </p> <hr style="text-rendering: \
inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: \
inherit;" /> <h1 style="font-size: 100%;text-rendering: inherit;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">adds an application icon to \
target source list.</h1> <h1 style="font-size: 100%;text-rendering: inherit;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">Make sure you have a 128x128 \
icon, or the icon won't display on Mac OS X.</h1> <h1 style="font-size: \
100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">Mac OSX notes : the application icon is added to a Mac OS X bundle so that \
Finder and friends show the right thing.</h1> <h1 style="font-size: \
100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">Win32 notes: the application icon(s) are compiled into the application</h1> \
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">There is some workaround in \
kde4_add_kdeinit_executable to make it possible for those applications as well.</h1> \
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">Parameters:</h1> <h1 style="font-size: \
100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">SRCS_VAR - specifies the list of source files</h1> <h1 style="font-size: \
100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">pattern - regular expression for searching application icons</h1> <h1 \
style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">Example: KDE4_ADD_APP_ICON( myapp_SOURCES \
"pics/cr*-myapp.png")</h1> <h1 style="font-size: 100%;text-rendering: \
inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Example: \
KDE4_ADD_APP_ICON( myapp_KDEINIT_SRCS "icons/oxygen/*/apps/myapp.png")</h1> <hr \
style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px \
solid #ddd;line-height: inherit;" /> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">normal file mode is not \
documentated and does not work</p></pre> </blockquote>
<p>On Dezember 15th, 2014, 9:16 nachm. CET, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
would still much prefer an API to match ecm_add_icons, as I noted at the start of \
this review. Would you be willing to do that? If not, I can probably find some time \
over Christmas to look at it.</p></pre> </blockquote>
<p>On Dezember 18th, 2014, 2:59 nachm. CET, <b>Ralf Habacker</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Just \
one question: As it turns out that the macro used in KDE4 only supports a "simple \
pattern" style and no single files, what is different or has been extended with KDE5 \
to require this now ?</p></pre> </blockquote>
<p>On Dezember 19th, 2014, 11:38 vorm. CET, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Best \
CMake practices include listing all source files in the CMakeLists.txt file, rather \
than globbing them. That way, CMake knows when a file has been added (or removed), \
because the CMakeLists.txt file will change, and so it will automatically reconfigure \
when you run <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">make</code>. The icon \
installation function (<code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">ecm_add_icons</code>) was \
changed to support and encourage that approach, and I think this function should also \
change to match it.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Additionally, I would like consistency \
between interfaces. Having ecm_add_app_icon behave completely differently to \
ecm_add_icons just makes things that much harder for users of e-c-m. They should use \
the same file naming scheme (or compatible schemes, at least), and similar arguments, \
in so far as they need similar information.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I'll admit it makes \
porting a little harder, but it should be possible to create a porting script without \
too much difficulty.</p></pre> </blockquote>
<p>On Januar 16th, 2015, 2:23 vorm. CET, <b>Jeremy Whiting</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ralf \
any updates on this patch?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">@Alex, you wrote</p> <blockquote style="text-rendering: inherit;padding: 0 \
0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 \
0.5em;line-height: inherit;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The icon installation function \
(ecm_add_icons) </p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">you are refering to ecm_install_icons ? </p> \
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">was changed to support and encourage that approach, and I think this \
function should also change to match it.</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">What could be matched ? As far as I can see only the \
ICONS parameter, all other parameter do not match by design. :-(</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Merging the ICONS parameter with recent ecm_add_app_icon parameter list \
will have the following syntax: </p> <ol style="padding: 0;text-rendering: \
inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;"> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">ecm_add_app_icon(<source_var> ICONS <icon> [<icon> \
[...]])</li> </ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">the additional mentioned syntax forms are not \
supported by ecm_install_icons so we are free to choose what we like. </p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">According to http://www.cmake.org/cmake/help/v3.0/command/install.html the \
mentioned term 'PATTERN' only supports '*' at the end of files and therefore does not \
fit into the recent implementation. </p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">So the term 'GLOB' \
which is defined in the cmake file command \
http://www.cmake.org/cmake/help/v3.0/command/file.html remains and fit into what is \
implemented in the patch</p> <ol style="padding: 0;text-rendering: inherit;margin: 0 \
0 0 2em;line-height: inherit;white-space: normal;"> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">ecm_add_app_icons(<source_var> GLOB <icon-glob-expression>) \
[1]</li> </ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">and</p> <ol style="padding: 0;text-rendering: \
inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;"> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">ecm_add_app_icon(<source_var< <icon-glob-expression>) [1]</li> \
</ol> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">because ecm_install_icons also have a compatibility \
mode to support old style parameter list: </p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">" From \
https://projects.kde.org/projects/kdesupport/extra-cmake-modules/repository/revisions/master/entry/modules/ECMInstallIcons.cmake
An old form of arguments will also be accepted::</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">ecm_install_icons(<icon_install_dir> \
[<l10n_code>])</h1> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">"</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">syntax 3 is what is already implemented by the recent patch. </p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Can we agree ? </p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">@Jeremey: 1. Syntax 3 is already \
implemented and need only a few spelling fixed before commit. 2. Currently I do not \
have any access to a Mac/OSX development machine, so I can only cover the windows \
part. Is there anyone having access to a Mac OSX development machine ? 3. If not I \
would remove the Mac OSX support for now.</p></pre> <br />
<p>- Ralf</p>
<br />
<p>On Dezember 15th, 2014, 9:01 vorm. CET, Ralf Habacker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Extra Cmake Modules, KDE Frameworks and Laurent Navet.</div>
<div>By Ralf Habacker.</div>
<p style="color: grey;"><i>Updated Dez. 15, 2014, 9:01 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This module, which has been migrated from the related \
KDE4 macto kde4_app_app_icon, supports platform specific application icon for Windows \
and Mac OSX.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On Windows this function depends on the external tool \
png2ico, which is provided by the kdewin-tools binary package. Sources are available \
at https://projects.kde.org/projects/kdesupport/kdewin.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>modules/ECMAddAppIcon.cmake <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121448/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/12/12/a05ee2b5-64e3-4e44-ae34-4e1b7110e5f1__ECMAddAppIcon.cmake">ECMAddAppIcon.cmake</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/12/15/8b3e226f-a70b-4998-983a-813730a436bf__ECMAddAppIcon.cmake">ECMAddAppIcon.cmake</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/12/15/8433995f-b88f-426d-af54-46aba635ae1e__ECMAddAppIcon.cmake">ECMAddAppIcon.cmake</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5652340160981345756==--
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic