[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 119798: Generating PkgConig files from ECM
From: "Harald Sitter" <sitter () kde ! org>
Date: 2014-08-14 23:16:02
Message-ID: 20140814231602.14667.12279 () probe ! kde ! org
[Download RAW message or body]
--===============0040253023997076697==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119798/#review64581
-----------------------------------------------------------
+1
- Harald Sitter
On Aug. 14, 2014, 11:10 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119798/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2014, 11:10 p.m.)
>
>
> Review request for Build System, KDE Frameworks and Harald Sitter.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> So we decided we wanted those .pc files, so I created a small script that generates \
> one, I haven't used pc in the past, so feedback is welcome.
>
> Diffs
> -----
>
> modules/ECMGeneratePkgConfigFile.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/119798/diff/
>
>
> Testing
> -------
>
> I added it in KCoreAddons, this is the patch:
> diff --git src/lib/CMakeLists.txt src/lib/CMakeLists.txt
> index 26eb5a1..3a07d1c 100644
> --- src/lib/CMakeLists.txt
> +++ src/lib/CMakeLists.txt
> @@ -188,4 +188,6 @@ install(FILES
>
> include(ECMGeneratePriFile)
> ecm_generate_pri_file(BASE_NAME KCoreAddons LIB_NAME KF5CoreAddons DEPS "core" \
> FILENAME_VAR PRI_FILENAME INCLUDE_INSTALL_DIR \
> ${KF5_INCLUDE_INSTALL_DIR}/KCoreAddons) +ecm_generate_pkgconfig_file(BASE_NAME \
> KCoreAddons LIB_NAME KF5CoreAddons DEPS Qt5Core FILENAME_VAR PC_FILENAME \
> INCLUDE_INSTALL_DIR ${KF5_INCLUDE_INSTALL_DIR}/KCoreAddons) +install(FILES \
> ${PC_FILENAME} DESTINATION ${ECM_PKGCONFIG_INSTALL_DIR}) install(FILES \
> ${PRI_FILENAME} DESTINATION ${ECM_MKSPECS_INSTALL_DIR})
> This is the result, on my system:
>
> Name: KF5CoreAddons
> Version: 5.1.0
> Libs: -L/home/kde-devel/kde5/lib64 -l/home/kde-devel/kde5/lib64
> Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons
> Requires: Qt5Core
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
--===============0040253023997076697==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119798/">https://git.reviewboard.kde.org/r/119798/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">+1</p></pre> <br />
<p>- Harald Sitter</p>
<br />
<p>On August 14th, 2014, 11:10 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Build System, KDE Frameworks and Harald Sitter.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Aug. 14, 2014, 11:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So we decided we wanted those .pc files, so I created \
a small script that generates one, I haven't used pc in the past, so feedback is \
welcome.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I added it in KCoreAddons, this is the patch:<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" />
diff --git src/lib/CMakeLists.txt src/lib/CMakeLists.txt<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
index 26eb5a1..3a07d1c 100644<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" />
--- src/lib/CMakeLists.txt<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" />
+++ src/lib/CMakeLists.txt<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> @@ -188,4 +188,6 @@ install(FILES</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">include(ECMGeneratePriFile)<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
ecm_generate_pri_file(BASE_NAME KCoreAddons LIB_NAME KF5CoreAddons DEPS "core" \
FILENAME_VAR PRI_FILENAME INCLUDE_INSTALL_DIR \
${KF5_INCLUDE_INSTALL_DIR}/KCoreAddons)<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
+ecm_generate_pkgconfig_file(BASE_NAME KCoreAddons LIB_NAME KF5CoreAddons DEPS \
Qt5Core FILENAME_VAR PC_FILENAME INCLUDE_INSTALL_DIR \
${KF5_INCLUDE_INSTALL_DIR}/KCoreAddons)<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> +install(FILES \
${PC_FILENAME} DESTINATION ${ECM_PKGCONFIG_INSTALL_DIR})<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
install(FILES ${PRI_FILENAME} DESTINATION ${ECM_MKSPECS_INSTALL_DIR})</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This is the result, on my system:</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Name: KF5CoreAddons<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" />
Version: 5.1.0<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" />
Libs: -L/home/kde-devel/kde5/lib64 -l/home/kde-devel/kde5/lib64<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" />
Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons <br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" />
Requires: Qt5Core</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>modules/ECMGeneratePkgConfigFile.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119798/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0040253023997076697==--
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic