[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 119260: Missing target dependency for GUI
From: "Vadim Zhukov" <persgray () gmail ! com>
Date: 2014-08-12 0:55:38
Message-ID: 20140812005538.14667.82062 () probe ! kde ! org
[Download RAW message or body]
--===============0706427891124077193==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119260/
-----------------------------------------------------------
(Updated Aug. 12, 2014, 12:55 a.m.)
Status
------
This change has been marked as submitted.
Review request for Build System and Tellico.
Repository: tellico
Description
-------
The "gui" target relies on data provided by "tellico-config" target. But there was no dependency chain \
between those, and this resulted in (sometimes) broken builds, especially involving Ninja backend for \
CMake. The patch below adds missing dependency and allows to compile Tellico on OpenBSD 100% time.
Please note that I do not have commit rights to the KDE repositories. That means, if the patch will be \
accepted, someone else will need to actually commit it. Thanks.
Diffs
-----
src/gui/CMakeLists.txt e44db7b
Diff: https://git.reviewboard.kde.org/r/119260/diff/
Testing
-------
OpenBSD/i386-CURRENT, KDE 4.13.3
Thanks,
Vadim Zhukov
--===============0706427891124077193==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119260/">https://git.reviewboard.kde.org/r/119260/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; \
-moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Build System and Tellico.</div>
<div>By Vadim Zhukov.</div>
<p style="color: grey;"><i>Updated Aug. 12, 2014, 12:55 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
tellico
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The "gui" target relies on data provided by \
"tellico-config" target. But there was no dependency chain between those, and this resulted in \
(sometimes) broken builds, especially involving Ninja backend for CMake. The patch below adds missing \
dependency and allows to compile Tellico on OpenBSD 100% time.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Please note that I do not have commit \
rights to the KDE repositories. That means, if the patch will be accepted, someone else will need to \
actually commit it. Thanks.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">OpenBSD/i386-CURRENT, KDE 4.13.3</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/gui/CMakeLists.txt <span style="color: grey">(e44db7b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119260/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0706427891124077193==--
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic