'Re: Review Request 119067: give a warning if using invalid (typically old KDE 3) categories'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: Review Request 119067: give a warning if using invalid (typically old KDE 3) categories
From:       "Jonathan Riddell" <jr () jriddell ! org>
Date:       2014-07-01 16:10:10
Message-ID: 20140701161010.22318.92168 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119067/
-----------------------------------------------------------

(Updated July 1, 2014, 4:10 p.m.)

Status
------

This change has been marked as submitted.

Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Repository: extra-cmake-modules

Description
-------

give a warning if using invalid (typically old KDE 3) categories
Lots and lots of icons still use KDE 3 categories which are no longer valid, give a warning when this is so

Diffs
-----

  modules/ECMInstallIcons.cmake ccbbfea266641e619ef618582e53a27461b1fff8 

Diff: https://git.reviewboard.kde.org/r/119067/diff/

Testing
-------

Thanks,

Jonathan Riddell

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119067/">https://git.reviewboard.kde.org/r/119067/</a>
     </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
 <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for Build System, Extra Cmake Modules and KDE Frameworks.</div>
<div>By Jonathan Riddell.</div>

<p style="color: grey;"><i>Updated July 1, 2014, 4:10 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">give a warning if using invalid (typically \
old KDE 3) categories Lots and lots of icons still use KDE 3 categories which are no longer valid, give a \
warning when this is so </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>modules/ECMInstallIcons.cmake <span style="color: \
grey">(ccbbfea266641e619ef618582e53a27461b1fff8)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119067/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

[prev in list] [next in list] [prev in thread] [next in thread] 