[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 115897: Remove FindDocBook*.cmake
From: "Alex Merry" <kde () randomguy3 ! me ! uk>
Date: 2014-02-23 14:58:50
Message-ID: 20140223145850.22875.19846 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 22, 2014, 6:29 p.m., Luigi Toscano wrote:
> > As this was already committed, can this RR be closed?
>
> Alex Merry wrote:
> Actually, I never committed this one, since I never got a ship it. I added the files to \
> kdoctools, but never removed them from e-c-m.
> Luigi Toscano wrote:
> Is a shipit really needed, given https://git.reviewboard.kde.org/r/115896/ ?
I tend to err on the side of caution. If you're of the view that this should get shipped, you \
could always give it the shipit :-)
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115897/#review50553
-----------------------------------------------------------
On Feb. 19, 2014, 11:45 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115897/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 11:45 p.m.)
>
>
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, David Faure, Kevin \
> Ottens, and Luigi Toscano.
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Remove FindDocBook*.cmake
>
> These are only really useful to kdoctools, so they may as well live
> there.
>
> (NB: after looking at how kdoctools uses the information from these files, I suspect they \
> won't even be needed for the compatibility macros that are intended to end up in \
> kde4support).
>
> Diffs
> -----
>
> find-modules/FindDocBookXML.cmake b6d623e4e5ca40cdda4c895a19a0dc273831703a
> find-modules/FindDocBookXSL.cmake a7320aed66b72c92f0286658e38b7fc32266790c
>
> Diff: https://git.reviewboard.kde.org/r/115897/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Merry
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115897/">https://git.reviewboard.kde.org/r/115897/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 22nd, 2014, 6:29 p.m. UTC, <b>Luigi Toscano</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">As this was already committed, can this RR be \
closed?</pre> </blockquote>
<p>On February 23rd, 2014, 11:52 a.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Actually, I never committed this one, since I \
never got a ship it. I added the files to kdoctools, but never removed them from e-c-m.</pre> \
</blockquote>
<p>On February 23rd, 2014, 2:36 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Is a shipit really needed, given \
https://git.reviewboard.kde.org/r/115896/ ? </pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">I tend to err on the side of caution. If \
you're of the view that this should get shipped, you could always give it the shipit \
:-)</pre> <br />
<p>- Alex</p>
<br />
<p>On February 19th, 2014, 11:45 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for Build System, Extra Cmake Modules, KDE Frameworks, David Faure, Kevin \
Ottens, and Luigi Toscano.</div> <div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Feb. 19, 2014, 11:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove \
FindDocBook*.cmake
These are only really useful to kdoctools, so they may as well live
there.
(NB: after looking at how kdoctools uses the information from these files, I suspect they \
won't even be needed for the compatibility macros that are intended to end up in \
kde4support).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>find-modules/FindDocBookXML.cmake <span style="color: \
grey">(b6d623e4e5ca40cdda4c895a19a0dc273831703a)</span></li>
<li>find-modules/FindDocBookXSL.cmake <span style="color: \
grey">(a7320aed66b72c92f0286658e38b7fc32266790c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115897/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic