'Re: Review Request 115775: Defer to CMake's find_dependency macro if it exists'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 115775: Defer to CMake's find_dependency macro if it exists
From:       "Alex Merry" <kde () randomguy3 ! me ! uk>
Date:       2014-02-21 11:17:48
Message-ID: 20140221111748.27041.97952 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115775/
-----------------------------------------------------------

(Updated Feb. 21, 2014, 11:17 a.m.)

Status
------

This change has been marked as submitted.

Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Repository: extra-cmake-modules

Description
-------

Defer to CMake's find_dependency macro if it exists

This will be available in CMake 3.0.0.  This way, we automatically pick
up any new features from it.

Diffs
-----

  modules/ECMPackageConfigHelpers.cmake 78017393afa6e35dd90df0bd15e08ceed9dff841 

Diff: https://git.reviewboard.kde.org/r/115775/diff/

Testing
-------

Built some frameworks with CMake 2.8.12 (still works) and CMake git (properly defers to CMake's \
version, as shown by the fact that packages only searched for with find_dependency() are not \
shown in the feature summary).

Thanks,

Alex Merry

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115775/">https://git.reviewboard.kde.org/r/115775/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
 <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for Build System, Extra Cmake Modules and KDE Frameworks.</div>
<div>By Alex Merry.</div>

<p style="color: grey;"><i>Updated Feb. 21, 2014, 11:17 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Defer to CMake&#39;s \
find_dependency macro if it exists

This will be available in CMake 3.0.0.  This way, we automatically pick
up any new features from it.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built some frameworks \
with CMake 2.8.12 (still works) and CMake git (properly defers to CMake&#39;s version, as shown \
by the fact that packages only searched for with find_dependency() are not shown in the feature \
summary).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>modules/ECMPackageConfigHelpers.cmake <span style="color: \
grey">(78017393afa6e35dd90df0bd15e08ceed9dff841)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115775/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 