[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 115496: Rename CMakePackageConfigHelpers to ECMPackageConfigHelpers
From: "Stephen Kelly" <steveire () gmail ! com>
Date: 2014-02-18 15:15:23
Message-ID: 20140218151523.1065.25649 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115496/#review50149
-----------------------------------------------------------
> Overriding a CMake package like this will just cause all sorts of
> headaches later on.
I tried to make the same point, but I wasn't believed :).
- Stephen Kelly
On Feb. 16, 2014, 5:54 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115496/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2014, 5:54 p.m.)
>
>
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Rename CMakePackageConfigHelpers to ECMPackageConfigHelpers
>
> Overriding a CMake package like this will just cause all sorts of
> headaches later on. In this particular case, projects that depended on
> CMake 2.8.13 or later (more likely 3.0.0) would fail with a message
> about removing the CMakePackageConfigHelpers file, but would have no way
> to do that while still using ECM.
>
> This also renames the configure_package_config_file() macro to
> ecm_configure_package_config_file(), so that anything including
> CMakePackageConfigHelpers afterwards does not overwrite the macro
> unexpectedly.
>
> For now, we keep a CMakePackageConfigHelpers.cmake file that just wraps
> ecm_configure_package_config_file() as configure_package_config_file()
> to keep the frameworks building while they are ported.
>
>
> Diffs
> -----
>
> modules/CMakePackageConfigHelpers.cmake 5d65e659f7a04d65aeb08fa99569e88dde89acf2
> modules/ECMPackageConfigHelpers.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/115496/diff/
>
>
> Testing
> -------
>
> kdesrc-build has got to KIO so far with no problems.
>
> If KJS includes ECMPackageConfigHelpers and uses \
> ecm_configure_package_config_file(), both KJS and KI18n configure and build \
> properly.
>
> Thanks,
>
> Alex Merry
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115496/">https://git.reviewboard.kde.org/r/115496/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> Overriding a CMake \
package like this will just cause all sorts of > headaches later on.
I tried to make the same point, but I wasn't believed :).</pre>
<br />
<p>- Stephen Kelly</p>
<br />
<p>On February 16th, 2014, 5:54 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Build System, Extra Cmake Modules and KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Feb. 16, 2014, 5:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Rename CMakePackageConfigHelpers to ECMPackageConfigHelpers
Overriding a CMake package like this will just cause all sorts of
headaches later on. In this particular case, projects that depended on
CMake 2.8.13 or later (more likely 3.0.0) would fail with a message
about removing the CMakePackageConfigHelpers file, but would have no way
to do that while still using ECM.
This also renames the configure_package_config_file() macro to
ecm_configure_package_config_file(), so that anything including
CMakePackageConfigHelpers afterwards does not overwrite the macro
unexpectedly.
For now, we keep a CMakePackageConfigHelpers.cmake file that just wraps
ecm_configure_package_config_file() as configure_package_config_file()
to keep the frameworks building while they are ported.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kdesrc-build has got to KIO so far with no problems.
If KJS includes ECMPackageConfigHelpers and uses ecm_configure_package_config_file(), \
both KJS and KI18n configure and build properly.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>modules/CMakePackageConfigHelpers.cmake <span style="color: \
grey">(5d65e659f7a04d65aeb08fa99569e88dde89acf2)</span></li>
<li>modules/ECMPackageConfigHelpers.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115496/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic