From kde-buildsystem Wed Jan 22 19:02:55 2014 From: Thiago Macieira Date: Wed, 22 Jan 2014 19:02:55 +0000 To: kde-buildsystem Subject: Re: Review Request 115234: Only set QT_STRICT_ITERATORS when not compiling with MSVC Message-Id: <5756999.D9OnzXdNCt () tjmaciei-mobl2> X-MARC-Message: https://marc.info/?l=kde-buildsystem&m=139041739218530 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1360000618626116746==" --===============1360000618626116746== Content-Type: multipart/signed; boundary="nextPart1516028.I1LQ0rW6bH"; micalg="pgp-sha1"; protocol="application/pgp-signature" --nextPart1516028.I1LQ0rW6bH Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On quarta-feira, 22 de janeiro de 2014 17:51:46, Alexander Richardson wrote: > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115234/ > ----------------------------------------------------------- > > Review request for Build System, Extra Cmake Modules and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > Only set QT_STRICT_ITERATORS when not compiling with MSVC > > On MSVC linker errors will happen when this flag is set. Or I could apply a fix to Qt too. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel Open Source Technology Center PGP/GPG: 0x6EF45358; fingerprint: E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358 --nextPart1516028.I1LQ0rW6bH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iD8DBQBS4BXfM/XwBW70U1gRAvtdAJ43vjjnRP6dBPZGi5EaZcmVGOO/cgCfajf8 XpCFCQIfpwKYYa6vtm4FY5w= =mj2c -----END PGP SIGNATURE----- --nextPart1516028.I1LQ0rW6bH-- --===============1360000618626116746== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem --===============1360000618626116746==--