[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 113863: Remove WINCE specific cmake code paths
From: "Stephen Kelly" <steveire () gmail ! com>
Date: 2013-11-18 14:41:17
Message-ID: 20131118144117.13814.30166 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113863/#review43892
-----------------------------------------------------------
Ship it!
Ship It!
- Stephen Kelly
On Nov. 18, 2013, 2:34 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113863/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2013, 2:34 p.m.)
>
>
> Review request for Build System and KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Removes WINCE specific code. It's not a supported platform anymore.
>
>
> Diffs
> -----
>
> tier1/kcoreaddons/src/lib/CMakeLists.txt a1f81f7
> tier1/kcoreaddons/src/lib/util/kuser_wince.cpp b96e4dc
> tier3/kinit/src/kdeinit/CMakeLists.txt 4ef0a9b
> tier3/kio/src/CMakeLists.txt 3800e85
> tier3/kprintutils/src/CMakeLists.txt da0b7d5
> tier4/kde4support/src/CMakeLists.txt 9046c96
>
> Diff: http://git.reviewboard.kde.org/r/113863/diff/
>
>
> Testing
> -------
>
> still builds.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113863/">http://git.reviewboard.kde.org/r/113863/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Stephen Kelly</p>
<br />
<p>On November 18th, 2013, 2:34 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Build System and KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Nov. 18, 2013, 2:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Removes WINCE specific code. It's not a supported platform \
anymore.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">still builds.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kcoreaddons/src/lib/CMakeLists.txt <span style="color: \
grey">(a1f81f7)</span></li>
<li>tier1/kcoreaddons/src/lib/util/kuser_wince.cpp <span style="color: \
grey">(b96e4dc)</span></li>
<li>tier3/kinit/src/kdeinit/CMakeLists.txt <span style="color: \
grey">(4ef0a9b)</span></li>
<li>tier3/kio/src/CMakeLists.txt <span style="color: grey">(3800e85)</span></li>
<li>tier3/kprintutils/src/CMakeLists.txt <span style="color: \
grey">(da0b7d5)</span></li>
<li>tier4/kde4support/src/CMakeLists.txt <span style="color: \
grey">(9046c96)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113863/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic