'Re: Review Request 112912: Skip cmake checks for C and C++ compilers'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: Review Request 112912: Skip cmake checks for C and C++ compilers
From:       "Alexander Neundorf" <neundorf () kde ! org>
Date:       2013-09-25 19:38:12
Message-ID: 20130925193812.10620.10286 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112912/#review40794
-----------------------------------------------------------

Looks good I think.
When committing this, I think you can also revert this patch \
http://quickgit.kde.org/?p=extra-cmake-modules.git&a=commitdiff&h=53679542f663dc74276b928e8749b082319826f4 \
 since if no language has been enabled, the file generated by \
write_basic_package_version_file() does not care about the architecture.

- Alexander Neundorf

On Sept. 24, 2013, 7:32 a.m., Daniele E. Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112912/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2013, 7:32 a.m.)
> 
> 
> Review request for Build System.
> 
> 
> Description
> -------
> 
> Skip cmake checks for C and C++ compilers
> 
> These are not needed, since there are no files to build, and just slow down the \
> execution of cmake 
> 
> Diffs
> -----
> 
> CMakeLists.txt d9a1405b959617f1775ced1b999f17f2b6e14ffe 
> 
> Diff: http://git.reviewboard.kde.org/r/112912/diff/
> 
> 
> Testing
> -------
> 
> cmake, make and make install still work
> 
> 
> Thanks,
> 
> Daniele E. Domenichelli
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112912/">http://git.reviewboard.kde.org/r/112912/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good I think. When \
committing this, I think you can also revert this patch \
http://quickgit.kde.org/?p=extra-cmake-modules.git&amp;a=commitdiff&amp;h=53679542f663dc74276b928e8749b082319826f4 \
 since if no language has been enabled, the file generated by \
write_basic_package_version_file() does not care about the architecture.</pre>  <br \
/>

<p>- Alexander</p>

<br />
<p>On September 24th, 2013, 7:32 a.m. UTC, Daniele E. Domenichelli wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Build System.</div>
<div>By Daniele E. Domenichelli.</div>

<p style="color: grey;"><i>Updated Sept. 24, 2013, 7:32 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Skip cmake checks for C and C++ compilers

These are not needed, since there are no files to build, and just slow down the \
execution of cmake</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">cmake, make and make install still work</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(d9a1405b959617f1775ced1b999f17f2b6e14ffe)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112912/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

[prev in list] [next in list] [prev in thread] [next in thread] 