[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 112901: Remove weird cmake indirections
From: "Alexander Neundorf" <neundorf () kde ! org>
Date: 2013-09-23 19:29:29
Message-ID: 20130923192929.11521.51251 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112901/#review40612
-----------------------------------------------------------
This flag can be removed completely (instead of being replaced by "SHARED"), \
add_library() automatically builds shared libs if BUILD_SHARED_LIBS is set to true \
(which it is in KDECMakeSettings.cmake)
- Alexander Neundorf
On Sept. 23, 2013, 5:08 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112901/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2013, 5:08 p.m.)
>
>
> Review request for Build System and KDE Frameworks.
>
>
> Description
> -------
>
> There were some un-reviewed cmake files where libraries would be defined with a \
> ${LIBRARY_TYPE}. It seems to be something coming from the KDE4 times that didn't \
> follow through.
> I propose to remove all the uses for the moment, it's not ever being set anyway.
>
>
> Diffs
> -----
>
> interfaces/kimproxy/library/CMakeLists.txt 36e55ef
> interfaces/kmediaplayer/CMakeLists.txt 3d1797d
> kdesu/CMakeLists.txt e526643
> kdewebkit/CMakeLists.txt cdc5835
> kfile/CMakeLists.txt e05137d
> khtml/CMakeLists.txt 4e1bb80
> kio/CMakeLists.txt 25dc6d9
> kio/misc/kntlm/CMakeLists.txt fe70a8d
> kjsembed/kjsembed/CMakeLists.txt 8ed55c1
> knewstuff/src/CMakeLists.txt c313981
> knotify/config/CMakeLists.txt 69e1c11
> kparts/CMakeLists.txt 6ab9391
> kpty/CMakeLists.txt 9a79827
> kross/core/CMakeLists.txt 52cd3d4
> kross/qts/CMakeLists.txt 1a30bd1
> kross/ui/CMakeLists.txt 9e7806d
> kutils/CMakeLists.txt 0cb281d
> staging/kemoticons/src/core/CMakeLists.txt f7fb463
> staging/ktextwidgets/src/CMakeLists.txt 4787c10
>
> Diff: http://git.reviewboard.kde.org/r/112901/diff/
>
>
> Testing
> -------
>
> Everything still builds
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112901/">http://git.reviewboard.kde.org/r/112901/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This flag can be removed \
completely (instead of being replaced by "SHARED"), add_library() \
automatically builds shared libs if BUILD_SHARED_LIBS is set to true (which it is in \
KDECMakeSettings.cmake) </pre>
<br />
<p>- Alexander</p>
<br />
<p>On September 23rd, 2013, 5:08 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Build System and KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Sept. 23, 2013, 5:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">There were some un-reviewed cmake files where libraries would be defined \
with a ${LIBRARY_TYPE}. It seems to be something coming from the KDE4 times that \
didn't follow through.
I propose to remove all the uses for the moment, it's not ever being set \
anyway.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Everything still builds</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/kimproxy/library/CMakeLists.txt <span style="color: \
grey">(36e55ef)</span></li>
<li>interfaces/kmediaplayer/CMakeLists.txt <span style="color: \
grey">(3d1797d)</span></li>
<li>kdesu/CMakeLists.txt <span style="color: grey">(e526643)</span></li>
<li>kdewebkit/CMakeLists.txt <span style="color: grey">(cdc5835)</span></li>
<li>kfile/CMakeLists.txt <span style="color: grey">(e05137d)</span></li>
<li>khtml/CMakeLists.txt <span style="color: grey">(4e1bb80)</span></li>
<li>kio/CMakeLists.txt <span style="color: grey">(25dc6d9)</span></li>
<li>kio/misc/kntlm/CMakeLists.txt <span style="color: grey">(fe70a8d)</span></li>
<li>kjsembed/kjsembed/CMakeLists.txt <span style="color: grey">(8ed55c1)</span></li>
<li>knewstuff/src/CMakeLists.txt <span style="color: grey">(c313981)</span></li>
<li>knotify/config/CMakeLists.txt <span style="color: grey">(69e1c11)</span></li>
<li>kparts/CMakeLists.txt <span style="color: grey">(6ab9391)</span></li>
<li>kpty/CMakeLists.txt <span style="color: grey">(9a79827)</span></li>
<li>kross/core/CMakeLists.txt <span style="color: grey">(52cd3d4)</span></li>
<li>kross/qts/CMakeLists.txt <span style="color: grey">(1a30bd1)</span></li>
<li>kross/ui/CMakeLists.txt <span style="color: grey">(9e7806d)</span></li>
<li>kutils/CMakeLists.txt <span style="color: grey">(0cb281d)</span></li>
<li>staging/kemoticons/src/core/CMakeLists.txt <span style="color: \
grey">(f7fb463)</span></li>
<li>staging/ktextwidgets/src/CMakeLists.txt <span style="color: \
grey">(4787c10)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112901/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic