[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 112772: Create an ecm_mark_as_autotest macro
From: "Alexander Neundorf" <neundorf () kde ! org>
Date: 2013-09-18 20:11:54
Message-ID: 20130918201154.2892.29580 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Sept. 17, 2013, 6:26 p.m., Alexander Neundorf wrote:
> > The macro does more than the name implies, additionally to marking it as test it \
> > also actually adds the test. So I'd prefer a different name.
> >
> > Having said that, the CMakeLists.txt in the various tests/ subdirs in KDE \
> > frameworks look all quite similar, they more or less all feature a quite similar \
> > macro, foo_unit_tests(). Maybe a more advanced function can be written which can \
> > be used in all those places ?
>
> Alexander Richardson wrote:
> I just played around with adding a new macro to replace the \
> <FRAMEWORK_NAME>_UNIT_TESTS macros which are in every autotests directory: \
> http://paste.kde.org/p11adaa09/
> Could something like this be considered for ecm? If so I will add some \
> documentation and create a review request for ecm.
> Aleix Pol Gonzalez wrote:
> Neundorf: well, the difference between mark_as_test and mark_as_autotest is that it \
> marks it as a test. Actually I think that mark_as_test is in fact a bit misleading, \
> because it's not marking it as a test, only making it build as a test.
> About foo_unit_tests, I don't hate the idea, but then I don't think it pays off \
> that much, if we go with that, we can just keep kde4_add_unit_test just as well.
Alex: IMO yes.
Aleix: if the function from Alex R. is generic enough to be usable by non \
KDE-projects, I think it would be useful to have in ecm. Still, having two macros \
ecm_mark_as_test() and ecm_mark_as_autotest() would IMO not be good, since they sound \
quite similar but do different things. I'd prefer a more powerful function which does \
more than just wrap two calls.
But that's just my opinion, I leave it up to Stephen.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112772/#review40240
-----------------------------------------------------------
On Sept. 17, 2013, 12:35 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112772/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2013, 12:35 p.m.)
>
>
> Review request for Build System and KDE Frameworks.
>
>
> Description
> -------
>
> Creates a function that will define a unit test with the project name (like it's \
> being done in KF5) and calls ecm_mark_as_test.
> This should help simplify the tests creation that at the moment is quite verbose.
>
>
> Diffs
> -----
>
> modules/ECMMarkAsTest.cmake f1e53e4
>
> Diff: http://git.reviewboard.kde.org/r/112772/diff/
>
>
> Testing
> -------
>
> Ported some tests in KF5, it worked.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112772/">http://git.reviewboard.kde.org/r/112772/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 17th, 2013, 6:26 p.m. UTC, \
<b>Alexander Neundorf</b> wrote:</p> <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">The macro does more than the name implies, \
additionally to marking it as test it also actually adds the test. So I'd prefer \
a different name.
Having said that, the CMakeLists.txt in the various tests/ subdirs in KDE frameworks \
look all quite similar, they more or less all feature a quite similar macro, \
foo_unit_tests(). Maybe a more advanced function can be written which can be used in \
all those places ?</pre> </blockquote>
<p>On September 17th, 2013, 9:34 p.m. UTC, <b>Alexander Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just played around \
with adding a new macro to replace the <FRAMEWORK_NAME>_UNIT_TESTS macros which \
are in every autotests directory: http://paste.kde.org/p11adaa09/
Could something like this be considered for ecm? If so I will add some documentation \
and create a review request for ecm. </pre> </blockquote>
<p>On September 17th, 2013, 11:03 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Neundorf: well, the \
difference between mark_as_test and mark_as_autotest is that it marks it as a test. \
Actually I think that mark_as_test is in fact a bit misleading, because it's not \
marking it as a test, only making it build as a test.
About foo_unit_tests, I don't hate the idea, but then I don't think it pays \
off that much, if we go with that, we can just keep kde4_add_unit_test just as \
well.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Alex: \
IMO yes.
Aleix: if the function from Alex R. is generic enough to be usable by non \
KDE-projects, I think it would be useful to have in ecm. Still, having two macros \
ecm_mark_as_test() and ecm_mark_as_autotest() would IMO not be good, since they sound \
quite similar but do different things. I'd prefer a more powerful function which \
does more than just wrap two calls.
But that's just my opinion, I leave it up to Stephen.</pre>
<br />
<p>- Alexander</p>
<br />
<p>On September 17th, 2013, 12:35 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Build System and KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Sept. 17, 2013, 12:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Creates a function that will define a unit test with the project name \
(like it's being done in KF5) and calls ecm_mark_as_test.
This should help simplify the tests creation that at the moment is quite \
verbose.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ported some tests in KF5, it worked.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>modules/ECMMarkAsTest.cmake <span style="color: grey">(f1e53e4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112772/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic