[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 112451: Actually install the modules in the ecm attic
From: "Alexander Neundorf" <neundorf () kde ! org>
Date: 2013-09-03 19:19:20
Message-ID: 20130903191920.31231.20583 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112451/#review39293
-----------------------------------------------------------
You may consider renaming the variables from ALLUPPERCASE_SOMETHING to \
CamelCase_SOMETHING, i.e. to DocBookXSL_* and DocBookXML_*, to follow the cmake \
guidelines for naming variables better. When doing that, please add that change here:
http://techbase.kde.org/Development/ECM_SourceIncompatChanges
- Alexander Neundorf
On Sept. 3, 2013, 12:45 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112451/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2013, 12:45 p.m.)
>
>
> Review request for Build System, KDE Frameworks and Luigi Toscano.
>
>
> Description
> -------
>
> When trying to properly split KDocTools I saw that FindDocBookXML.cmake and \
> FindDocBookXSL.cmake were at an attic directory that was not being processed.
> This patch adds the directory to be used and fixes the installation so it works. It \
> looks weird to me that this was not the case and maybe I'm missing something. \
> Please tell me if that's the case.
>
> Diffs
> -----
>
> attic/modules/FindDocBookXML.cmake
> attic/modules/FindDocBookXSL.cmake
>
> Diff: http://git.reviewboard.kde.org/r/112451/diff/
>
>
> Testing
> -------
>
> Installs and seems to work.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112451/">http://git.reviewboard.kde.org/r/112451/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You may consider \
renaming the variables from ALLUPPERCASE_SOMETHING to CamelCase_SOMETHING, i.e. to \
DocBookXSL_* and DocBookXML_*, to follow the cmake guidelines for naming variables \
better. When doing that, please add that change here:
http://techbase.kde.org/Development/ECM_SourceIncompatChanges</pre>
<br />
<p>- Alexander</p>
<br />
<p>On September 3rd, 2013, 12:45 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Build System, KDE Frameworks and Luigi Toscano.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Sept. 3, 2013, 12:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When trying to properly split KDocTools I saw that FindDocBookXML.cmake \
and FindDocBookXSL.cmake were at an attic directory that was not being processed.
This patch adds the directory to be used and fixes the installation so it works. It \
looks weird to me that this was not the case and maybe I'm missing something. \
Please tell me if that's the case.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Installs and seems to work.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>attic/modules/FindDocBookXML.cmake <span style="color: grey">()</span></li>
<li>attic/modules/FindDocBookXSL.cmake <span style="color: grey">()</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112451/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic