[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request 112136: e-c-m: Add a separate block for clang definitions.
From: "Alexander Neundorf" <neundorf () kde ! org>
Date: 2013-08-20 19:37:17
Message-ID: 20130820193717.17308.60396 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112136/#review38235
-----------------------------------------------------------
Ship it!
If that works for you, go ahead.
- Alexander Neundorf
On Aug. 17, 2013, 10:31 p.m., Raphael Kubo da Costa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112136/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2013, 10:31 p.m.)
>
>
> Review request for Build System, Milian Wolff and Alexander Neundorf.
>
>
> Description
> -------
>
> Add a separate block for clang definitions.
>
> Sharing compiler settings between GCC and clang does not always work: there
> are flags (such as "-fno-check-new" or "-fno-reorder-blocks") that are
> specific to GCC, and nothing stops these incompatibilities from becoming
> bigger in the future.
>
> Conversely, a separate clang block allows us to pass some additional flags
> to clang that would have required yet another if() in the GCC block. For
> now, this amounts to "-fdelayed-template-parsing".
>
> (For KDE4, we also need -Wno-return-type-c-linkage because kdepim's
> ktexteditorkabcbridge.cpp exports a function that returns a QString with C
> linkage, but I hope this can be solved in a different way for kdepim5).
>
> Last but not least, checks for bad GCC allocators or support for some flags
> which are always present in clang can be avoided altogether when we know the
> compiler we are using.
>
>
> Diffs
> -----
>
> kde-modules/KDECompilerSettings.cmake 4a9f760b971870c8963cb43bf1b13599ff39a265
>
> Diff: http://git.reviewboard.kde.org/r/112136/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raphael Kubo da Costa
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112136/">http://git.reviewboard.kde.org/r/112136/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If that works for you, \
go ahead.</pre> <br />
<p>- Alexander</p>
<br />
<p>On August 17th, 2013, 10:31 p.m. UTC, Raphael Kubo da Costa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Build System, Milian Wolff and Alexander Neundorf.</div>
<div>By Raphael Kubo da Costa.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2013, 10:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add a separate block for clang definitions.
Sharing compiler settings between GCC and clang does not always work: there
are flags (such as "-fno-check-new" or "-fno-reorder-blocks") \
that are specific to GCC, and nothing stops these incompatibilities from becoming
bigger in the future.
Conversely, a separate clang block allows us to pass some additional flags
to clang that would have required yet another if() in the GCC block. For
now, this amounts to "-fdelayed-template-parsing".
(For KDE4, we also need -Wno-return-type-c-linkage because kdepim's
ktexteditorkabcbridge.cpp exports a function that returns a QString with C
linkage, but I hope this can be solved in a different way for kdepim5).
Last but not least, checks for bad GCC allocators or support for some flags
which are always present in clang can be avoided altogether when we know the
compiler we are using.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kde-modules/KDECompilerSettings.cmake <span style="color: \
grey">(4a9f760b971870c8963cb43bf1b13599ff39a265)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112136/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic