On Thursday 29 November 2012, Stephen Kelly wrote:
> Alexander Neundorf wrote:
> > On Tuesday 06 November 2012, Stephen Kelly wrote:
> >> Alexander Neundorf wrote:
> >> > On Friday 26 October 2012, Alexander Neundorf wrote:
> >> >> On Thursday 18 October 2012, Alexander Neundorf wrote:
> >> >> > Hi,
> >> >> > 
> >> >> > in kdelibs we require since more than 2 years cmake .2.6.4, since
> >> >> > then many improvements and fixes have gone into cmake, and we
> >> >> > cannot make use of them.
> >> > 
> >> > Ok, I pushed this change to the kdelibs 4.10 branch.
> >> 
> >> Thanks.
> >> 
> >> So what can we now do in kde buildsystems to modernize them and make
> >> them ready for KF5?
> >> 
> >>  * Use find_package instead of macro_optional_find_package?
> > 
> > Yes.
> > When committing those changes, it would probably be good to mention in
> > the commit message that packages can be skipped by initially setting
> > CMAKE_DISABLE_FIND_PACKAGE_<package> to TRUE.
> 
> Done in kdepimlibs.
> 
> >>  * Port from macro_feature_log to set_package_properties?
> > 
> > Yes.
> 
> Done in kdepimlibs.
> 
> >>  * Port to CMAKE_AUTOMOC? Would probably require a way to disable
> >>  automoc4.
> 
> You didn't comment on this part. Is that because you are
> reading/considering my patch? I think it's an important patch to get in to
> the next release, as kdepimlibs depends on the latest released version of
> kdelibs.


No, I just forgot to reply on this one.
If it works, just go ahead.

Alex
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem