On Tuesday 06 November 2012, Stephen Kelly wrote:
> Alexander Neundorf wrote:
> > On Friday 26 October 2012, Alexander Neundorf wrote:
> >> On Thursday 18 October 2012, Alexander Neundorf wrote:
> >> > Hi,
> >> > 
> >> > in kdelibs we require since more than 2 years cmake .2.6.4, since then
> >> > many improvements and fixes have gone into cmake, and we cannot make
> >> > use of them.
> > 
> > Ok, I pushed this change to the kdelibs 4.10 branch.
> 
> Thanks.
> 
> So what can we now do in kde buildsystems to modernize them and make them
> ready for KF5?
> 
>  * Use find_package instead of macro_optional_find_package?

Yes.
When committing those changes, it would probably be good to mention in the 
commit message that packages can be skipped by initially setting 
CMAKE_DISABLE_FIND_PACKAGE_<package> to TRUE.

>  * Port from macro_feature_log to set_package_properties?

Yes.

>  * Port to CMAKE_AUTOMOC? Would probably require a way to disable automoc4.
>  * Use set(CMAKE_LINK_INTERFACE_LIBRARIES "") as kde4_add_library does.

Maybe. This would be in FindKDE4Internal.cmake, right ?
I think this wouldn't help a lot. It is hidden in kde4_add_library() now, and 
then it would be hidden in FindKDE4Internal.cmake.
Ok, then it would also apply to libraries which are built using the normal 
add_library() call.... there are not many of those.

>  * Port to GenerateExportHeader?

You know that better than I do.

Alex
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem