[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: 4.9.3 tarballs available (for packagers)
From:       Brad King <brad.king () kitware ! com>
Date:       2012-11-06 15:39:49
Message-ID: 50992F45.8080103 () kitware ! com
[Download RAW message or body]

On 11/06/2012 10:28 AM, Stephen Kelly wrote:
> Rex Dieter wrote:
> > On 11/06/2012 07:55 AM, Andrea Scarpino wrote:
> > > Did anyone built qyoto? I cannot build it with cmake 2.8.10, see
> > > https://bugs.kde.org/show_bug.cgi?id=309652 for info.
> > 
> > Confirmed on fedora too, seems to be some sort of regression or behavior
> > change in cmake-2.8.10 (I followed up on the bug too).
> 
> http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/5145/focus=5174
> 
> It may be necessary to adapt.

Yes.  The relevant change in CMake is here:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7195aca5

In response to the first report of trouble with this change we have
since added a note about our policy for external language support:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=854369fd

The fix suggested here:

 https://bugs.kde.org/show_bug.cgi?id=309652#c1
 https://bugzilla.redhat.com/show_bug.cgi?id=872829#c2

is:

> if (${CMAKE_VERSION} VERSION_LESS "2.8.10")
> set (COMPILER_SUPPORT_SUBDIRECTORY "")
> else (${CMAKE_VERSION} VERSION_LESS "2.8.10")
> set (COMPILER_SUPPORT_SUBDIRECTORY "/${CMAKE_VERSION}")
> endif (${CMAKE_VERSION} VERSION_LESS "2.8.10")
> configure_file(${script_dir}/CMakeCSharpCompiler.cmake.in
> ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY}${COMPILER_SUPPORT_SUBDIRECTORY}/CMakeCSharpCompiler.cmake \
> IMMEDIATE @ONLY)

but would be better written (also untested):

 if(NOT CMAKE_PLATFORM_INFO_DIR) # pre-2.8.10
   set(CMAKE_PLATFORM_INFO_DIR ${CMAKE_BINARY_DIR}${CMAKE_FILES_DIRECTORY})
 endif()
 configure_file(${script_dir}/CMakeCSharpCompiler.cmake.in
   ${CMAKE_PLATFORM_INFO_DIR}/CMakeCSharpCompiler.cmake IMMEDIATE @ONLY)

-Brad
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem


[prev in list] [next in list] [prev in thread] [next in thread]