--===============8093804448421334627== Content-Type: multipart/alternative; boundary="===============6375545877401771594==" --===============6375545877401771594== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107049/#review21002 ----------------------------------------------------------- Have a look at http://www.cmake.org/Wiki/CMake_Released_Versions and/or htt= p://www.cmake.org/Wiki/CMake_Version_Compatibility_Matrix , to find out wha= t changed in which version of CMake. Beside that, I can't really comment on the python-related changes, I don't = know much about python. - Alexander Neundorf On Oct. 26, 2012, 9:50 a.m., Luca Beltrame wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107049/ > ----------------------------------------------------------- > = > (Updated Oct. 26, 2012, 9:50 a.m.) > = > = > Review request for Build System. > = > = > Description > ------- > = > Fix CMake Python macros. > = > The internal CMake macros in kdelibs for Python are a > mess, and make installing for different Python versions (2 and 3) very > hard, especially since some distributions change the Python library name > slightly. > = > The fix is to use proper CMake macros from upstream, FindPythonInterp > and FindPythonLibs. > = > However I'm not sure in which CMake versions these are. If it's 2.6.x, I'= ll also push to stable branch. > = > = > Diffs > ----- > = > CMakeLists.txt af7a81573408952240517735ea3f4107a9be77e8 = > kpythonpluginfactory/CMakeLists.txt 41fa0fed576cafacc4cdaa4f7ca657b41c7= beba3 = > = > Diff: http://git.reviewboard.kde.org/r/107049/diff/ > = > = > Testing > ------- > = > Compiled with Python 3 and Python 2. > = > = > Thanks, > = > Luca Beltrame > = > --===============6375545877401771594== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107049/

Have a loo=
k at http://www.cmake.org/Wiki/CMake_Released_Versions and/or http://www.cm=
ake.org/Wiki/CMake_Version_Compatibility_Matrix , to find out what changed =
in which version of CMake.
Beside that, I can't really comment on the python-related changes, I do=
n't know much about python.

- Alexander

On October 26th, 2012, 9:50 a.m., Luca Beltrame wrote:

Review request for Build System.

By Luca Beltrame.

Updated Oct. 26, 2012, 9:50 a.m.

Descripti= on

Fix CMake Python macros.

The internal CMake macros in kdelibs for Python are a
mess, and make installing for different Python versions (2 and 3) very
hard, especially since some distributions change the Python library name
slightly.

The fix is to use proper CMake macros from upstream, FindPythonInterp
and FindPythonLibs.

However I'm not sure in which CMake versions these are. If it's 2.6=
.x, I'll also push to stable branch.

Testing <= /h1>

Compiled with Python 3 and Python 2.

Diffs=

CMakeLists.txt (af7a81573408952240517735ea= 3f4107a9be77e8)
kpythonpluginfactory/CMakeLists.txt (41fa0= fed576cafacc4cdaa4f7ca657b41c7beba3)

--===============6375545877401771594==-- --===============8093804448421334627== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem --===============8093804448421334627==--