'Review Request: Fix CMake Python macros.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Review Request: Fix CMake Python macros.
From:       "Luca Beltrame" <einar () heavensinferno ! net>
Date:       2012-10-26 9:14:36
Message-ID: 20121026091436.3448.50440 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107049/
-----------------------------------------------------------

Review request for Build System.

Description
-------

Fix CMake Python macros.

The internal CMake macros in kdelibs for Python are a
mess, and make installing for different Python versions (2 and 3) very
hard, especially since some distributions change the Python library name
slightly.

The fix is to use proper CMake macros from upstream, FindPythonInterp
and FindPythonLibs.

However I'm not sure in which CMake versions these are. If it's 2.6.x, I'll=
 also push to stable branch.

Diffs
-----

  CMakeLists.txt af7a81573408952240517735ea3f4107a9be77e8 =

  kpythonpluginfactory/CMakeLists.txt 41fa0fed576cafacc4cdaa4f7ca657b41c7be=
ba3 =

Diff: http://git.reviewboard.kde.org/r/107049/diff/

Testing
-------

Compiled with Python 3 and Python 2.

Thanks,

Luca Beltrame

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107049/">http://git.reviewboard.kde.org/r/107049/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for Build System.</div>
<div>By Luca Beltrame.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix CMake Python \
macros.

The internal CMake macros in kdelibs for Python are a
mess, and make installing for different Python versions (2 and 3) very
hard, especially since some distributions change the Python library name
slightly.

The fix is to use proper CMake macros from upstream, FindPythonInterp
and FindPythonLibs.

However I&#39;m not sure in which CMake versions these are. If it&#39;s 2.6.x, I&#39;ll also \
push to stable branch.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled with Python \
3 and Python 2.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(af7a81573408952240517735ea3f4107a9be77e8)</span></li>

 <li>kpythonpluginfactory/CMakeLists.txt <span style="color: \
grey">(41fa0fed576cafacc4cdaa4f7ca657b41c7beba3)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107049/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

[prev in list] [next in list] [prev in thread] [next in thread] 