From kde-buildsystem Sun Oct 07 20:02:26 2012 From: Alexander Neundorf Date: Sun, 07 Oct 2012 20:02:26 +0000 To: kde-buildsystem Subject: Re: Requiring cmake 2.8.9 for kdelibs 4.10 ? Message-Id: <201210072202.26491.neundorf () kde ! org> X-MARC-Message: https://marc.info/?l=kde-buildsystem&m=134964019109663 On Thursday 04 October 2012, Stephen Kelly wrote: > Alexander Neundorf wrote: > > On Monday 01 October 2012, David Faure wrote: > >> On Monday 01 October 2012 09:53:22 Stephen Kelly wrote: > >> > Instead, I say we should do a 'pain free' update to 2.8.7 now, and an > >> > update to 2.8.11 later. > >> > >> Yes. > > > > I disagree. > > > > If we upgrade now, I want to have at least 2.8.8 > > This has a lof of work for supporting cmake's Config.cmake files, and > > with 2.8.8 I can finally point users how to create properly working > > (including Windows) Config.cmake files with reasonable effort. > > I don't see why that can't wait a little while longer. > > What is Windows-specific about how we create Config files currently? Getting the Config files right so that they are relocatable, which is especially important under Windows, is not trivial. Look e.g. here, this also does something I don't fully understand, it uses a cmake variable coming from somewhere else: https://projects.kde.org/projects/playground/accessibility/libkdeaccessibilityclient It may work, but I don't know. It looks strange at least. So, CMake 2.8.8 comes with the module CMakePackageConfigHelpers.cmake, which makes this much simpler: http://www.cmake.org/cmake/help/v2.8.8/cmake.html#module:CMakePackageConfigHelpers This is IMO a big point for requiring 2.8.8. I want to be able to point people to use this stuff so they end up with working Config-files which also are maintainable. This will make my life easier and result in better working Config files for libraries. Alex _______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem