[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Review Request: Support Python 3.2's new method of handling byte compiled files in PythonMacros.
From: "Alexander Neundorf" <neundorf () kde ! org>
Date: 2012-10-04 19:05:38
Message-ID: 20121004190538.6387.24156 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106707/#review19923
-----------------------------------------------------------
Ship it!
Looks straightforward and obvious.
Beside that, I don't know much about python byte code compiling.
- Alexander Neundorf
On Oct. 3, 2012, 10:43 a.m., Luca Beltrame wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106707/
> -----------------------------------------------------------
> =
> (Updated Oct. 3, 2012, 10:43 a.m.)
> =
> =
> Review request for Build System.
> =
> =
> Description
> -------
> =
> Python 3.2 changed the compile mechanism by creating a __pycache__ direct=
ory. This obviously breaks a lot of stuff that assumed that pyc files were =
stored in the same directory as the py files. This change adds a check, and=
adjusts files only in case Python 3.2 is found. Notice that currently I ha=
ve way of testing if the suffix (*cpython) is the same on all supported OSe=
s.
> =
> =
> Diffs
> -----
> =
> cmake/modules/PythonMacros.cmake 774c6b2d8eb5f9bafaf7e73da1108bd347a736=
67 =
> =
> Diff: http://git.reviewboard.kde.org/r/106707/diff/
> =
> =
> Testing
> -------
> =
> No more errors are produced when building PyKDE4 with Python 3.2.3
> =
> =
> Thanks,
> =
> Luca Beltrame
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106707/">http://git.reviewboard.kde.org/r/106707/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks straightforward \
and obvious. Beside that, I don't know much about python byte code compiling.
</pre>
<br />
<p>- Alexander</p>
<br />
<p>On October 3rd, 2012, 10:43 a.m., Luca Beltrame wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Build System.</div>
<div>By Luca Beltrame.</div>
<p style="color: grey;"><i>Updated Oct. 3, 2012, 10:43 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Python 3.2 changed the compile mechanism by creating a __pycache__ \
directory. This obviously breaks a lot of stuff that assumed that pyc files were \
stored in the same directory as the py files. This change adds a check, and adjusts \
files only in case Python 3.2 is found. Notice that currently I have way of testing \
if the suffix (*cpython) is the same on all supported OSes.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No more errors are produced when building PyKDE4 with Python 3.2.3</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/PythonMacros.cmake <span style="color: \
grey">(774c6b2d8eb5f9bafaf7e73da1108bd347a73667)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106707/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic