[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: hidden visibility
From:       David Faure <faure () kde ! org>
Date:       2012-02-18 22:51:36
Message-ID: 1726546.TrOrqkan0K () asterix ! site
[Download RAW message or body]

On Friday 17 February 2012 18:31:58 Alexander Neundorf wrote:
> I'm not quite sure in the code above in which cases there is a "bad
> allocator", and whether "-Werror=return-type -fvisibility-inlines-hidden" is
> something everybody should do or not.

-Werror=return-type is completely unrelated. It has been moved there because
this is inside  if (GCC_IS_NEWER_THAN_4_2), and this flag didn't exist before 
4.2. See commit 66027ca3a94848246eef2618a342ddc6ece0a00c.

Bad allocator is probably about old versions of gcc too. I would think we can 
drop all these "old gcc" hacks in frameworks.

I don't know about -fvisibility-inlines-hidden.

-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5

_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]