[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: review FindFLEX.cmake
From:       "Yury G.  Kudryashov" <urkud.urkud () gmail ! com>
Date:       2011-09-16 18:40:14
Message-ID: j5056k$pfo$1 () dough ! gmane ! org
[Download RAW message or body]

Alexander Neundorf wrote:

> Hi,
> 
> I think this one looks good as it is.
> If somebody wants to, it could be changed to all-lowercase and empty
> endif() statements.

Are you talking about attic/modules/FindFlex.cmake (didn't found 
FindFLEX.cmake)?

If yes, I see two problems:

1. FLEX_LIBRARY and FLEX_INCLUDE_DIR are not documented;

2. It is not possible to specify whether one needs both executable and 
library+headers, or just executable, or just library. What about 
find_package(Flex COMPONENTS EXECUTABLE LIBRARY)?

About the second point, I never used flex, so probably one never need only 
one of these components. In this case, just ignore this point.
-- 
Yury G. Kudryashov,
mailto: urkud@mccme.ru

_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]