[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: PolKit and KDE4_AUTH_POLICY_FILES_INSTALL_DIR
From:       Michael Jansen <info () michael-jansen ! biz>
Date:       2011-05-08 16:39:12
Message-ID: 1734936.xNgjQphSd2 () gambit ! local ! michael-jansen ! biz
[Download RAW message or body]

On Monday 07 March 2011 17:03:53 Dario Freddi wrote:
> Hi guys, sorry if I am answering just now, but somehow this mail slipped
> from my inbox. However.
> 
> On Thursday 17 February 2011 22:33:41 Alexander Neundorf wrote:
> > set(KDE4_AUTH_POLICY_FILES_INSTALL_DIR
> > ${POLKITQT-1_POLICY_FILES_INSTALL_DIR} CACHE STRING "Where policy files
> > generated by KAuth will be installed" FORCE)
> > 
> > 
> > The FORCE makes it impossible to override using -D or something. It will
> > always be set to the value used in this line, i.e.
> > ${POLKITQT-1_POLICY_FILES_INSTALL_DIR}.
> > 
> > Dario, is this what you wanted ?
> 
> Not really, actually. Instead, one should be able to change that variable to
> point to the correct directory (usually /usr/share/polkit-1/actions), so it
> is indeed my mistake.
> 
> > > The way I think this should work is:
> > > 1) Use KDE4_AUTH_POLICY_FILES_INSTALL_DIR if specified, else use
> > > KDEDIR
> > > 2) If path different from polkit-qt AUTH_POLICY_FILES_INSTALL_DIR
> > > then
> > > display an appropriate warning
> > > 3) Install to the requested location, it's then up to the dev to fix
> > > if
> > > needed by either moving the files or by building polkit-qt
> > > themselves.
> > 
> > Dario ?
> 
> Makes sense, but the warning should be shown if the directory is actually
> different from /usr... in any case, as installing those in the same dir that
> polkit-qt-1 specifies doesn't necessarily mean that the location is
> correct.

Since i couldn't stand it anymore i pushed a fix today. Please revert if the 
solution is considered inappropriate (or tell me to revert).

http://quickgit.kde.org/?p=kdelibs.git&a=commit&h=8d65adce7b3e2262e464ce989bd0add197f416a3
> 
> > Alex
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]