From kde-buildsystem  Tue Aug 24 19:45:27 2010
From: Christophe Giboudeaux <cgiboudeaux () gmail ! com>
Date: Tue, 24 Aug 2010 19:45:27 +0000
To: kde-buildsystem
Subject: Re: Please review: cmake check for Cagibi
Message-Id: <4C742157.4030105 () gmail ! com>
X-MARC-Message: https://marc.info/?l=kde-buildsystem&m=128267903722403

Hi,


Le 24/08/2010 21:31, Friedrich W. H. Kossebau a écrit :
> Mardi, le 24 août 2010, à 21:23, vous avez écrit:
>> > On Tuesday 24 August 2010, Friedrich W. H. Kossebau wrote:
>>> > > Mardi, le 24 août 2010, à 20:40, vous avez écrit:
>>> > > So okay to commit the attached patch, both to trunk and 4.5 branch?
>> > 
>> > No, no.
>> > 
>> > Index: kdebase/runtime/cmake/modules/CMakeLists.txt
>> > ===================================================================
>> > --- kdebase/runtime/cmake/modules/CMakeLists.txt	(Revision 1157717)
>> > +++ kdebase/runtime/cmake/modules/CMakeLists.txt	(Arbeitskopie)
>> > @@ -2,6 +2,7 @@
>> > 
>> >  # don't glob for the files, we don't want to install e.g.
>> > FindLibKNotification-1.cmake
>> >  set(cmakeFiles FindCLucene.cmake
>> > +               FindCagibiDaemon.cmake
>> >                 FindSLP.cmake)
>> > 
>> >  set(module_install_dir ${DATA_INSTALL_DIR}/cmake/modules )
>> > 
>> > 
>> > Do you *really* want to install that file ?
>> > I think that shouldn't be necessary.
> Alright. What about this attached version? :)
> 

[cut]

>  )
> +macro_optional_find_package(CagibiDaemon)
> +macro_log_feature( CAGIBI_DAEMON_FOUND
> +  "Cagibi daemon" "SSDP (Simple Service Discovery Protocol, used by UPnP) cache/proxy daemon (RUNTIME DEPENDENCY)" "http://websvn.kde.org/trunk/kdesupport/cagibi/" FALSE
> +  "0.1.1" "Provides UPnP device/service listing in the network:/ kio-slave."
> +)
>  
Sorry but I still think it's a bad idea. macro_log_feature() should only
report missing build dependencies or in the future we'll have all kind
of not-so-useful messages about runtime deps in different modules.

If Cagibi has no usefulness at build time, look for it at runtime only.
a kFatal/kWarning was suggested last week.

a README.packagers would be enough (that's what we have in eg. kdepim).

Christophe.




_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem