[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: Please review: cmake check for Cagibi
From:       Maciej Mrozowski <reavertm () gmail ! com>
Date:       2010-08-24 19:24:50
Message-ID: 201008242124.50895.reavertm () gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Tuesday 24 of August 2010 21:14:32 Friedrich W. H. Kossebau wrote:
> Mardi, le 24 août 2010, à 20:40, vous avez écrit:
> > On Monday 23 August 2010, Friedrich W. H. Kossebau wrote:
> > The following 4 lines should be good enough:
> > 
> > find_program(CAGIBI_DAEMON NAMES cagibid)
> > include(FindPackageHandleStandardArgs)
> > find_package_handle_standard_args(Cagibi  DEFAULT_MSG  CAGIBI_DAEMON)
> > mark_as_advanced(CAGIBI_FOUND CAGIBI_DAEMON)
> > 
> > 
> > Support for checking the version will come soon to FPHSA(), don't start
> > with FOO_MIN_VERSION now.
> > 
> > Maybe you could also rename the file to FindCagibiDaemon.cmake to make
> > very clear what it does, as name for the variable I would suggest
> > CAGIBI_DAEMON_EXECUTABLE.
> 
> So okay to commit the attached patch, both to trunk and 4.5 branch?

Please do not install FindCagibiDeamon.cmake. Actually kdebase/runtime should 
not install any .cmake modules but that's different story.

-- 
regards
MM

["signature.asc" (application/pgp-signature)]

_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem


[prev in list] [next in list] [prev in thread] [next in thread]