[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Please review: cmake check for Cagibi
From: Alexander Neundorf <neundorf () kde ! org>
Date: 2010-08-24 18:40:23
Message-ID: 201008242040.23332.neundorf () kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Monday 23 August 2010, Friedrich W. H. Kossebau wrote:
> Hi,
>
> following up to my and your emails on "How to test for a D-Bus run-time
> dependency?" last tuesday here please find and then comment on my \
> proposal to test for the existance of cagibi during the build, so there \
> is some hint at every build of kdebase on this optional dependency.
>
> The patch adds to kdebase/runtime/CMakeLists.txt the test of Cagibi, the
> file FindCagibi.cmake should end up in kdebase/runtime/cmake/modules.
>
> There are currently only two versions of Cagibi released, 0.1.0 and \
> 0.1.1. The problem is that the version cannot really be checked at the \
> moment, as the version string is nowhere noted in the install.
> But as Cagibi may not be spread that much currently, most people will see
> the demand for the version 0.1.1 at least. And this is better than the
> current situation.
>
> Okay to commit both to trunk and 4.5 branch?
>
> Cheers
> Friedrich
The following 4 lines should be good enough:
find_program(CAGIBI_DAEMON NAMES cagibid)
include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(Cagibi DEFAULT_MSG CAGIBI_DAEMON)
mark_as_advanced(CAGIBI_FOUND CAGIBI_DAEMON)
Support for checking the version will come soon to FPHSA(), don't start \
with FOO_MIN_VERSION now.
Maybe you could also rename the file to FindCagibiDaemon.cmake to make very \
clear what it does, as name for the variable I would suggest \
CAGIBI_DAEMON_EXECUTABLE.
Alex
[Attachment #5 (text/html)]
<html><head><meta name="qrichtext" content="1" /></head><body \
style="font-size:10pt;font-family:Monospace"> <p>On Monday 23 August 2010, \
Friedrich W. H. Kossebau wrote:</p> <p>> Hi,</p>
<p>></p>
<p>> following up to my and your emails on "How to test for a D-Bus \
run-time</p> <p>> dependency?" last tuesday here please find and \
then comment on my proposal</p> <p>> to test for the existance of cagibi \
during the build, so there is some hint</p> <p>> at every build of \
kdebase on this optional dependency.</p> <p>></p>
<p>> The patch adds to kdebase/runtime/CMakeLists.txt the test of \
Cagibi, the</p> <p>> file FindCagibi.cmake should end up in \
kdebase/runtime/cmake/modules.</p> <p>></p>
<p>> There are currently only two versions of Cagibi released, 0.1.0 and \
0.1.1.</p> <p>> The problem is that the version cannot really be checked \
at the moment, as</p> <p>> the version string is nowhere noted in the \
install.</p> <p>> But as Cagibi may not be spread that much currently, \
most people will see</p> <p>> the demand for the version 0.1.1 at least. \
And this is better than the</p> <p>> current situation.</p>
<p>></p>
<p>> Okay to commit both to trunk and 4.5 branch?</p>
<p>></p>
<p>> Cheers</p>
<p>> Friedrich</p>
<p></p>
<p>The following 4 lines should be good enough:</p>
<p></p>
<p>find_program(CAGIBI_DAEMON NAMES cagibid)</p>
<p>include(FindPackageHandleStandardArgs)</p>
<p>find_package_handle_standard_args(Cagibi DEFAULT_MSG \
CAGIBI_DAEMON)</p> <p>mark_as_advanced(CAGIBI_FOUND CAGIBI_DAEMON)</p>
<p></p>
<p></p>
<p>Support for checking the version will come soon to FPHSA(), don't start \
with FOO_MIN_VERSION now.</p> <p></p>
<p>Maybe you could also rename the file to FindCagibiDaemon.cmake to make \
very clear what it does, as name for the variable I would suggest \
CAGIBI_DAEMON_EXECUTABLE.</p> <p></p>
<p>Alex</p>
<p></p>
</body></html>
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic