[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: can't install kdebase, needs root
From:       Alexander Neundorf <neundorf () kde ! org>
Date:       2010-06-27 21:11:59
Message-ID: 201006272311.59705.neundorf () kde ! org
[Download RAW message or body]

On Friday 25 June 2010, Michael Jansen wrote:
> On Donnerstag 24 Juni 2010 23:24:36 Alexander Neundorf wrote:
> > On Thursday 24 June 2010, Michael Jansen wrote:
> > > And another question. Shouldn't kdebindings (pykde4) start to use the
> > > same var? If i understand correctly i currently have to override
> > > PYTHON_SITE_PACKAGES_DIR there to not install into my distro python
> > > prefix.
> >
> > Yes.
> >
> > Alex
>
> Ok. I tried to prepare a patch but encountered a problem.
>
> PYTHON_SITE_PACKAGES_DIR was always an absolute path
> PYTHON_SITE_PACKAGES_INSTALL_DIR is a relative path
>
> which breaks lines like these:
>
> INSTALL(
> 	CODE "EXECUTE_PROCESS(COMMAND ${CMAKE_COMMAND}
> 		 -DTARGET=${PYTHON_SITE_PACKAGES_INSTALL_DIR}/PyQt4/uic/pykdeuic4.py
> 		-DLINK_NAME=${BIN_INSTALL_DIR}/pykdeuic4 -P
> ${cmake_module_dir}/create_exe_symlink.cmake)" )
>
> Why is PYTHON_SITE_PACKAGES_INSTALL_DIR a relative path anyway? I have
> never seen those in cmake before.

Actually relative paths are recommended over absolute paths for install 
locations in cmake, they make some things easier.
In KDE I opted for absolute paths because at some point it seemed like a 
better choice to me.
Now in this case I thought I'd use a relative one for the python stuff.

But maybe to be consistent with the rest of KDE it should be also initialized 
to an absolute path. To do this, just prepend "${CMAKE_INSTALL_PREFIX}/" in 
FindPythonLibrary.cmake where the variable is set.

Alex
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]