On Saturday 04 July 2009, Ralf Habacker wrote:
> Alexander Neundorf schrieb:
> > On Thursday 02 July 2009, Ralf Habacker wrote:
> >> SVN commit 990260 by habacker:
> >>
> >> Account for CMAKE_EXECUTABLE_SUFFIX in KDE4_*_EXECUTABLE .shell names,
> >> since that is how they are created. by cygwin ports maintainer
> >
> > cygwin ?
>
> yes
>
> > Is anybody trying to build KDE4 for cygwin ?
>
> see
> http://sourceforge.net/mailarchive/message.php?msg_name=4A40846D.4000607%40
>users.sourceforge.net and
> http://sourceforge.net/mailarchive/message.php?msg_name=cfbb9574d343e573421
>fa69acebef295%40email.freenet.de for more details.
> It would be nice, if someone with detailed cmake know how could help him.

Can you please ask him to join the kde-buildsystem mailing list ?

Is this part of the patch really correct ?

--- origsrc/kdelibs-4.2.4/cmake/modules/KDE4Macros.cmake
+++ src/kdelibs-4.2.4/cmake/modules/KDE4Macros.cmake
@@ -567,6 +569,8 @@ macro (KDE4_ADD_PLUGIN _target_NAME _wit
 
    if (_first_SRC)
       set_target_properties(${_target_NAME} PROPERTIES PREFIX "")
+   else (_first_SRC)
+      set_target_properties(${_target_NAME} PROPERTIES PREFIX "lib")
    endif (_first_SRC)
 
    if (WIN32)

---------------

This patch is inside the following macro:
macro (KDE4_ADD_PLUGIN _target_NAME _with_PREFIX)
#is the first argument is "WITH_PREFIX" then keep the standard "lib" prefix, 
otherwise set the prefix empty


I.e. the old version removed the default "lib" prefix on UNIX systems by 
default. If WITH_PREFIX was used, it did not remove the "lib" prefix on UNIX 
systems, but also on Windows systems it did not add a "lib" prefix. 
With the patch it seems to add a "lib" prefix, also on Windows, also for MSVC.

Do we want that ?


Also, the patch doesn't seem to be complete, since there is still the 
following code in FindKDE4Internal.cmake:

if (WIN32)
   if(CYGWIN)
      message(FATAL_ERROR "Cygwin is NOT supported, use mingw or MSVC to build 
KDE4.")
   endif(CYGWIN)


Alex
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem