[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: [PATCH] FindSoprano.cmake - prefer locally installed version
From:       Allen Winter <winter () kde ! org>
Date:       2009-05-12 21:22:46
Message-ID: 200905121722.47180.winter () kde ! org
[Download RAW message or body]

On Tuesday 12 May 2009 2:31:32 pm Alexander Neundorf wrote:
> On Tuesday 12 May 2009, Sebastian Trüg wrote:
> > On Monday 11 May 2009 20:14:59 Alexander Neundorf wrote:
> > > On Monday 11 May 2009, Sebastian Trüg wrote:
> > > > The attached patch first looks for Soprano in the install prefix and
> > > > only afterwards in the standard dirs. It is a typical problem that
> > > > stuff fails to link since cmake tries to link against the globally
> > > > installed Soprano instead of the local development one.
> > > >
> > > > May I commit?
> > >
> > > No.
> > >
> > > Since cmake 2.6.1 (we require 2.6.2) the FIND_XXX() commands have a
> > > new "HINTS" keyword, which can be used instead of PATHS. The difference
> > > is that the directories listed with HINTS will be searched before all
> > > other directories, not after.
> > > Can you please use this ?
> >
> > new patch attached.
> 
> I'd say it looks good now :-)
> 
+1 from me too

please make sure to update the copy in kdesupport/akonadi also
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

[prev in list] [next in list] [prev in thread] [next in thread]