[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: KDE/kdelibs
From:       Alexander Neundorf <neundorf () kde ! org>
Date:       2009-04-15 21:15:29
Message-ID: 200904152315.29287.neundorf () kde ! org
[Download RAW message or body]

Hi Helio,

On Wednesday 15 April 2009, Helio Chissini de Castro wrote:
> SVN commit 954017 by helio:
>
> Add lzma/xz compression algorithm handling.
> Original code by Per Øyvind Karlsen, <peroyvind@mandriva.org>
> Minor modifications bu Helio Castro <helio@kde.org>
> Reviewed by David Faure
>
>
>  M  +3 -0      CMakeLists.txt
>  M  +2 -0      ConfigureChecks.cmake
>  A             cmake/modules/FindLibLZMA.cmake

Since a few weeks we have a commit policy for kdelibs/cmake/modules/:
http://techbase.kde.org/Policies/CMake_Commit_Policy

You added a new cmake file, so this requires an explicit ok on the buildsystem 
list. So we do that now.

* FindLibLZMA.cmake works only if pkg-config is available.
Please change this so that it also works without pkg-config, but it's ok if it 
prefers the information it gets from pkg-config if pkg-config is successfull.
Please also 

* Use a "PC_" prefix for the call to PKG_SEARCH_MODULE, so the variables 
created by PKG_SEARCH_MODULE all have this prefix and don't get mixed up with 
variables set via FIND_XXX(), see FindLibXml2.cmake as an example.

* FIND_PACKAGE_HANDLE_STANDARD_ARGS() is used only in the Windows-branch, 
why ?

* Indentation in the IF(NOT WIN32) part is messed up.

Alex
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

[prev in list] [next in list] [prev in thread] [next in thread]