From kde-buildsystem  Sun Apr 12 07:23:05 2009
From: Thiago Macieira <thiago () kde ! org>
Date: Sun, 12 Apr 2009 07:23:05 +0000
To: kde-buildsystem
Subject: Re: [PATCH] bug 174806
Message-Id: <200904120923.20260.thiago () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-buildsystem&m=123952106122334
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============1975451579=="

--===============1975451579==
Content-type: multipart/signed; boundary=nextPart1341648.Jho8SnfBn4;
 protocol="application/pgp-signature"; micalg=pgp-sha1
Content-transfer-encoding: 7bit

--nextPart1341648.Jho8SnfBn4
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Michael Witten wrote:
>2009/4/11 Thiago Macieira <thiago@kde.org>:
>> Well, if we detect Python 2.6, then we should install to the KDE
>> prefix by default. The problem then is, of course, the surprise
>> factor: if someone upgrades, suddenly KDE starts installing to the
>> wrong path.
>>
>> I recommend, instead, that we default to the KDE prefix and, if Python
>> 2.5 or earlier is detected, we print a big warning at the end of the
>> cmake run, saying that you will not be able to run and that you should
>> set the PYTHON_SITE_PACKAGES_DIR variable instead. Even make it a
>> fatal error.
>
>I have already done ALL of this work.
>
>Did nobody read my patches?

I have done that now.

>I have been too busy to to clean up the asthaetic issues that have
>kept it out of trunk, but I honestly believe that my solution is the
>fullest and most superior suggestion (and implementation) yet.

You're right, your solution is by far the most complete one.

However, there are still problems.

If a user ran cmake with a path that doesn't exist *yet*, it'll still try=20
to install to the system prefix. This is a reasonable use-case for the firs=
t=20
time you try to build KDE. Not to mention the surprise factor of that=20
changing in the second run.=20

Also, if root is installing to /opt/kde4, the files will by default end up=
=20
in /usr/lib/python2.6, which is outside the prefix.=20

I repeat once again: unless the user tells us so in the command-line, do=20
not install anything outside the prefix.

As for the cosmetic changes, it's necessary to address them, since there=20
are a lot of them, which means reviewing your patches is hard. For=20
example, there's a new file called ParseArgs.cmake which adds a macro that=
=20
is not used anywhere.

=2D-=20
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

--nextPart1341648.Jho8SnfBn4
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQBJ4ZbaM/XwBW70U1gRAiRzAKCjq+D8dsvapN+oK1L87BcH3W0qhgCcCm3A
INjETr+l6i5ad8ck+55V3oA=
=B4qH
-----END PGP SIGNATURE-----

--nextPart1341648.Jho8SnfBn4--

--===============1975451579==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

--===============1975451579==--