[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: [PATCH] bug 174806
From:       Michael Witten <mfwitten () gmail ! com>
Date:       2009-04-11 14:53:57
Message-ID: b4087cc50904110753g5d11ed11r9088fdb05849663b () mail ! gmail ! com
[Download RAW message or body]

On Fri, Apr 10, 2009 at 23:18, Raphael Kubo da Costa <kubito@gmail.com> wrote:
>
> Doesn't simply letting the user specify PYTHON_SITE_PACKAGES_DIR via
> cmake -D work just as well

Sure, but that's annoying, because that should never be necessary
unless you're doing something strange.

Also, that's only one small problem. PYTHON_INSTALL is badly
implemented and improperly used. That's a terrible combination.

Unfortunately, I've been busy with other tasks recently. My last patch
submission (quite a while ago) only suffered from what I consider
topical disagreements (one problem was there to begin with, actually).

Until I get back to my patches (hopefully soon), I do indeed suggest
the simple patch to allow -D on the command line; there should also be
a warning if it is not set that it must be set.
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]