[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: [PATCH] bug 174806
From:       Alexander Neundorf <neundorf () kde ! org>
Date:       2009-03-25 20:49:39
Message-ID: 200903252149.39995.neundorf () kde ! org
[Download RAW message or body]

On Wednesday 25 March 2009, Michael Witten wrote:
> Hello again!
>
> I've updated the page for the following bug:
>
>     https://bugs.kde.org/show_bug.cgi?id=174806
>
> with this attachment:
>
>     https://bugs.kde.org/attachment.cgi?id=32379
>
> and this comment:
>
> Sorry for getting back WAY too late on this one. I've got excuses, but
> who cares... ;-)
>
> I've attached a tarball that contains 3 pataches: kdelibs.patch,
> kdebase.patch, kdebindings.patch.
>
> The main patch is kdelibs.patch, which cleans up some cruft and adds 3
> new CMake commands: PARSE_ARGS(), ADD_PYTHON(), and INSTALL_PYTHON().

Just as a first comment, the macros and variables should all be "namespaced", 
i.e. they should be PYTHON_ADD_SOMETHING() and also 
PYTHON_INSTALL_SOMETHING(). 
This makes it clear where they come from.
More tomorrow :-)

Alex
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]