From kde-buildsystem  Thu Jan 29 21:01:51 2009
From: Hasso Tepper <hasso () kde ! org>
Date: Thu, 29 Jan 2009 21:01:51 +0000
To: kde-buildsystem
Subject: Re: A problem linking phonon kded module
Message-Id: <200901292301.51759.hasso () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-buildsystem&m=123326296910372

Alexander Neundorf wrote:
> I haven't looked at the file yet, but it seems pkgconfig is used and
> the results are directly put into the variables.

Yeah.

> As you see, this is bad.
> Instead pkgconfig should be used only optionally, and the results
> should be used only as hints for FIND_LIBRARY/PATH/FILE/PROGRAM().
> The variable used for pkgconfig should also have a "PC_" prefix, so
> they don't get messed up with the actual "public" variables.
> See kdelibs/cmake/modules/FindLibXml2.cmake for an example.

And FindPulseAudio.cmake is not the only one, seems. At least 
FindIDN.cmake in kdenetwork breaks the same way here.


regards,

-- 
Hasso Tepper
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem