From kde-buildsystem Tue Nov 11 08:47:24 2008 From: Eva Brucherseifer Date: Tue, 11 Nov 2008 08:47:24 +0000 To: kde-buildsystem Subject: Re: [Decibel] kdesupport/decibel Message-Id: <200811110947.26332.eva.brucherseifer () basyskom ! de> X-MARC-Message: https://marc.info/?l=kde-buildsystem&m=122646620716334 Am Dienstag, 11. November 2008 schrieb Matthew Woehlke: > Alexander Neundorf wrote: > > On Tuesday 11 November 2008, Matthew Woehlke wrote: > >> Alexander Neundorf wrote: > > > > ... > > > >>> I just saw the patch. So yes, try to stay consistent within the file, > >>> lowercase is preferred. > >> > >> Ok. But I'm still curious what "consistency" you're thinking of: > > > > Yes, this looks like mostly uppercase. > > So either stay with all-uppercase (and make the few lowercase commands > > also uppercase) or convert everything to lower case. > > Too late :-), I already checked it in sans case change. But it's better > anyway to do such things in a separate commit. > > Alex: do you speak for decibel devs? Else, any decibel devs have a > preference here? Otherwise I'll plan to upper-case* everything tomorrow > or Wednesday, if I can remember that long ;-), and if no one beats me to > it. (And please don't think you'd be stepping on my toes if anyone wants > to do it themselves :-).) I think it doesn't really matter - I think it's mixed mostly because copy/pasting from various sources. So I'd say, just say change it to uppercase. Cheers, eva > > (*...just because that seems to be predominant in decibel) > > -- > Matthew > Please do not quote my e-mail address unobfuscated in message bodies. -- Eva Brucherseifer Managing Director basysKom GmbH Robert-Bosch-Str. 7 | 64293 Darmstadt | Germany Tel: +49 6151 3969-961 | Fax: -736 | Mobile: +49 170 5533642 eva.brucherseifer@basyskom.de | www.basyskom.de Handelsregister: Darmstadt HRB 9352 Geschaeftsfuehrung: Eva Brucherseifer _______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem