[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: kdesupport/decibel
From:       Alexander Neundorf <neundorf () kde ! org>
Date:       2008-11-10 22:44:37
Message-ID: 200811102344.39184.neundorf () kde ! org
[Download RAW message or body]

On Monday 10 November 2008, Matthew Woehlke wrote:
> Alexander Neundorf wrote:
> > On Monday 10 November 2008, Matthew Woehlke wrote:
> >> Can I commit this small adjustment also?
> >>
> >> Index: decibel/CMakeLists.txt
> >> ===================================================================
> >> --- decibel/CMakeLists.txt      (revision 882361)
> >> +++ decibel/CMakeLists.txt      (working copy)
> >> @@ -2,7 +2,7 @@
> >>   CMAKE_MINIMUM_REQUIRED(VERSION 2.6.0)
> >>   cmake_policy(SET CMP0003 NEW)
> >>
> >> -set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules")
> >> +SET(CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules"
> >> ${CMAKE_MODULE_PATH})
> >
> > Short answer, yes, I'd say commit.
> > (but please try to use consistent lower/uppercasing for the commands, it
> > seems the other commands are lowercase, so please do it for this one
> > too).
>
> They are? I see one lower-case if() block, and the rest seems to be
> upper-case. I can avoid making a case change in the commit if you would
> prefer (actually I simply didn't notice that the diff resulted in a case
> change), although upper seems to be more consistent, at least within
> this particular CMakeLists.txt.

I just saw the patch. So yes, try to stay consistent within the file, 
lowercase is preferred.

Alex
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]