From kde-buildsystem  Sun Jun 29 22:45:28 2008
From: Thiago Macieira <thiago () kde ! org>
Date: Sun, 29 Jun 2008 22:45:28 +0000
To: kde-buildsystem
Subject: Re: Reducing excess linkage - cmake 2.6 IMPORTED targets and
Message-Id: <200806291945.34469.thiago () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-buildsystem&m=121478074225633
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============1086898948=="

--===============1086898948==
Content-Type: multipart/signed;
  boundary="nextPart6268453.MQiTeVlnqP";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart6268453.MQiTeVlnqP
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Alexander Neundorf wrote:
>> The only QtXml user is kross/core/action.h
>> fromDomElement/toDomElement. I don't think this is enough to link all
>> krosscore users against QtXml.
>
>Hmm, is it a real problem if QtXml is listed here ? It shouldn't add
> more package dependencies (QtXml should be installed anyways when KDE4
> is installed).

That's not the point.

The point is that most applications won't be using QtXml symbols, so they=20
shouldn't be linking *directly* to QtXml. If they do use them, then they=20
should link.

>> > kio
>> > LINK_INTERFACE_LIBRARIES "kdeui;kdecore;${QT_QTNETWORK_LIBRARY};
>>
>> ${QT_QTXML_LIBRARY}"
>> Could you please justify QtNetwork and QtXml here? None of public kio
>> headers need QtNetwork (actually, QtNetwork is not worth bundling with
>> anything). QtXml users are kbookmark*.h (internal method) and
>> davjob.h. In my opinion, they are not good enough reason to pull
>> QtXml. Application can specify it manually. However, it is true that
>> there will be relatively many linking failures due to missing QtXml.
>
>That's the justification. Avoiding too much breakage.

I don't agree. If we do this at all, we should do the proper cleanup. If=20
the application doesn't use QtDBus directly, they shouldn't link to=20
QtDBus directly.

Every application and library has to explicitly list all of its direct=20
dependencies and only the direct ones. Anything else is an error.

This interface stuff is just a convenience.

>> > kdeui
>> > LINK_INTERFACE_LIBRARIES
>> > "kdecore;${QT_QTSVG_LIBRARY};${QT_QTGUI_LIBRARY}"
>>
>> It is true that kdeui exposes QtSvg, but kdeui is used extensively in
>> KDE (directly and via kio and its dependencies). QtSvg is needed used
>> by ~13 targets in official KDE modules whereas kdeui is probably
>> needed by ~90% of all KDE applications. Hence, I don't think it is
>> worth to have in kdeui interface libraries.
>
>Hmm, see above. Is it a real problemm if it is listed ?
>I don't have a strong opinion about it, but I'd like to keep breakage
> low.

I think we should break now, before the problem is too widespread.

>> > kdecore
>> >  LINK_INTERFACE_LIBRARIES
>> > "${QT_QTDBUS_LIBRARY};${QT_QTCORE_LIBRARY}")
>>
>> It is true that kdecore/util/klauncher_iface.h exposes QtDBus
>> interface. But the need for it rarely comes from klauncher_iface
>> users. It is true, that QtDBus is needed by ~40% KDE applications
>> (libraries, kioslaves and other stuff usually don't need it) so you
>> would get a lot of linking failures due to QtDBus.
>
>That's why I'd really like to have it here.

See above.

=2D-=20
=A0 Thiago Macieira =A0- =A0thiago (AT) macieira.info - thiago (AT) kde.org
=A0 =A0 PGP/GPG: 0x6EF45358; fingerprint:
=A0 =A0 E067 918B B660 DBD1 105C =A0966C 33F5 F005 6EF4 5358

--nextPart6268453.MQiTeVlnqP
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQBIaBCIM/XwBW70U1gRAkEDAJ9Txgxohe87R4XUPWWf4FAMwutmwACgjVJt
awR42PGQT98P3QZyt0IkC4Q=
=UwS6
-----END PGP SIGNATURE-----

--nextPart6268453.MQiTeVlnqP--

--===============1086898948==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

--===============1086898948==--