[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: Re: Reducing excess linkage - cmake 2.6 IMPORTED targets and
From: Alexander Neundorf <neundorf () kde ! org>
Date: 2008-06-18 21:57:47
Message-ID: 200806190002.37952.neundorf () kde ! org
[Download RAW message or body]
Hi,
On Wednesday 11 June 2008, Alexander Neundorf wrote:
> On Tuesday 03 June 2008, Alexander Neundorf wrote:
> > On Thursday 29 May 2008, Dirk Mueller wrote:
> > ...
> >
> > > All fine for me, go ahead. I can help with fixing/testing it somewhen
> > > end of next week.
> >
> > Ok, done.
> >
> > On Tuesday 03 June 2008, Modestas Vainius wrote:
> > > Hi,
> > >
> > > Tuesday 03 June 2008, jūs rašėte:
> > > > As discussed with Dirk, make the link interface empty by default,
> > > > i.e. by default apps linking to libfoo won't be linked to the libs
> > > > libfoo.so links against too anymore.
> > >
> > > Are you aware that we at Debian have already done this but to a lesser
> > > extent?
> >
> > Yes.
> >
> > > (resetting all LINK_INTERFACE_LIBRARIES to empty is too drastic, imho).
> >
> > Setting them empty by default is the conclusion from my discussion with
> > Dirk at LinuxTag.
attached you can find a patch which reduces the "link interfaces" of the libs
from kdelibs significantly.
I am able to build kdelibs this way.
I guess all other modules break, i.e. won't link. I don't have the time and
computing power to fix this for all modules, so your help is needed here.
Please apply the attached patch to kdelibs and enable the option
KDE4_ENABLE_EXPERIMENTAL_LIB_EXPORT.
Then the dependencies in KDELibsDependencies.cmake will look like this:
SET("dummy_LIB_DEPENDS" "")
SET("kde3support_LIB_DEPENDS" "kio;kdeui;kdecore;/opt/qt-copy/lib/libQt3Support.so")
SET("kdecore_LIB_DEPENDS" "/opt/qt-copy/lib/libQtDBus.so;/opt/qt-copy/lib/libQtCore.so;-lpthread")
SET("kdefakes_LIB_DEPENDS" "")
SET("kdesu_LIB_DEPENDS" "")
SET("kdeui_LIB_DEPENDS" "kdecore;/opt/qt-copy/lib/libQtSvg.so;/opt/qt-copy/lib/libQtGui.so")
SET("kdnssd_LIB_DEPENDS" "")
SET("kfile_LIB_DEPENDS" "kio;kdeui;kdecore")
SET("khtml_LIB_DEPENDS" "kparts;kjs;kio;kdeui;kdecore")
SET("kimproxy_LIB_DEPENDS" "")
SET("kio_LIB_DEPENDS" "kdeui;kdecore;/opt/qt-copy/lib/libQtNetwork.so;/opt/qt-copy/lib/libQtXml.so")
SET("kjs_LIB_DEPENDS" "")
SET("kjsapi_LIB_DEPENDS" "")
SET("kjsembed_LIB_DEPENDS" "")
SET("kmediaplayer_LIB_DEPENDS" "")
SET("knewstuff2_LIB_DEPENDS" "")
SET("knotifyconfig_LIB_DEPENDS" "")
SET("kntlm_LIB_DEPENDS" "")
SET("kparts_LIB_DEPENDS" "kio;kdeui;kdecore")
SET("kpty_LIB_DEPENDS" "")
SET("krosscore_LIB_DEPENDS" "kdecore;/opt/qt-copy/lib/libQtScript.so;/opt/qt-copy/lib/libQtXml.so")
SET("krossqtsplugin_LIB_DEPENDS" "")
SET("krossui_LIB_DEPENDS" "krosscore")
SET("ktexteditor_LIB_DEPENDS" "")
SET("kunittest_LIB_DEPENDS" "")
SET("kutils_LIB_DEPENDS" "")
SET("kwalletbackend_LIB_DEPENDS" "")
SET("solid_LIB_DEPENDS" "")
SET("threadweaver_LIB_DEPENDS" "")
i.e. almost empty. I don't know if these settings are ideal. There were a lot
of undefined references to X stuff in targets which linked to kdeui, so maybe
X11_LIBRARIES should be added to the link interface of kdeui.
There were also several errors with undefined references to libz functions in
targets which link to kio, so maybe libz should be added to the kio link
interface.
What do you think ?
To the debian packagers: please use a clean kdelibs from svn and build with
this patch. It should do what you want. I really strongly suggest that you
stay as close to svn as possible.
Once applied, all other modules have to be built and where required the
missing libraries to the TARGET_LINK_LIBRARIES() commands have to be added.
If that works, and the release time agrees, this has to be committed all at
once at a monday.
Alex
["kdelibs-minimal-libs.patch" (text/x-diff)]
Index: khtml/kmultipart/CMakeLists.txt
===================================================================
--- khtml/kmultipart/CMakeLists.txt (revision 821552)
+++ khtml/kmultipart/CMakeLists.txt (working copy)
@@ -9,7 +9,7 @@
kde4_add_plugin(kmultipart WITH_PREFIX ${kmultipart_PART_SRCS})
-target_link_libraries(kmultipart ${KDE4_KPARTS_LIBS} )
+target_link_libraries(kmultipart ${KDE4_KPARTS_LIBS} ${ZLIB_LIBRARY})
install(TARGETS kmultipart DESTINATION ${PLUGIN_INSTALL_DIR} )
Index: khtml/CMakeLists.txt
===================================================================
--- khtml/CMakeLists.txt (revision 821552)
+++ khtml/CMakeLists.txt (working copy)
@@ -326,9 +326,11 @@
kde4_add_library(khtml SHARED ${khtml_LIB_SRCS})
-target_link_libraries(khtml ${KDE4_KPARTS_LIBS} ktexteditor kjs ${KDE4_PHONON_LIBS} \
${JPEG_LIBRARIES} ${GIF_LIBRARIES} ${PNG_LIBRARIES} ) +target_link_libraries(khtml \
${KDE4_KPARTS_LIBS} ktexteditor kjs ${KDE4_PHONON_LIBS} ${JPEG_LIBRARIES} \
${GIF_LIBRARIES} ${PNG_LIBRARIES} ${X11_LIBRARIES})
-set_target_properties(khtml PROPERTIES VERSION ${KDE_NON_GENERIC_LIB_VERSION} \
SOVERSION ${KDE_NON_GENERIC_LIB_SOVERSION} ) +set_target_properties(khtml PROPERTIES \
VERSION ${KDE_NON_GENERIC_LIB_VERSION} + \
SOVERSION ${KDE_NON_GENERIC_LIB_SOVERSION} + \
LINK_INTERFACE_LIBRARIES "kparts;kjs;kio;kdeui;kdecore")
set(CREATE_HASH_TABLE ${CMAKE_SOURCE_DIR}/kjs/create_hash_table )
Index: kde3support/CMakeLists.txt
===================================================================
--- kde3support/CMakeLists.txt (revision 821552)
+++ kde3support/CMakeLists.txt (working copy)
@@ -78,9 +78,12 @@
kde4_add_library(kde3support SHARED ${kde3support_LIB_SRCS})
-target_link_libraries(kde3support ${KDE4_KPARTS_LIBS} ${KDE4_KPTY_LIBS} \
${QT_QTXML_LIBRARY} ${QT_QT3SUPPORT_LIBRARY} ${KDE4_KFILE_LIBS}) \
+target_link_libraries(kde3support ${KDE4_KPARTS_LIBS} ${KDE4_KPTY_LIBS} \
${QT_QTXML_LIBRARY} ${QT_QT3SUPPORT_LIBRARY} ${KDE4_KFILE_LIBS} ${X11_LIBRARIES})
-set_target_properties(kde3support PROPERTIES VERSION ${GENERIC_LIB_VERSION} \
SOVERSION ${GENERIC_LIB_SOVERSION} ) +set_target_properties(kde3support PROPERTIES \
VERSION ${GENERIC_LIB_VERSION} + \
SOVERSION ${GENERIC_LIB_SOVERSION} + \
LINK_INTERFACE_LIBRARIES "kio;kdeui;kdecore;${QT_QT3SUPPORT_LIBRARY}") +
install(TARGETS kde3support ${INSTALL_TARGETS_DEFAULT_ARGS})
########### install files ###############
Index: kate/plugins/kdatatool/CMakeLists.txt
===================================================================
--- kate/plugins/kdatatool/CMakeLists.txt (revision 821552)
+++ kate/plugins/kdatatool/CMakeLists.txt (working copy)
@@ -6,7 +6,7 @@
kde4_add_plugin(ktexteditor_kdatatool ${ktexteditor_kdatatool_PART_SRCS})
-target_link_libraries(ktexteditor_kdatatool ${KDE4_KDECORE_LIBS} ktexteditor )
+target_link_libraries(ktexteditor_kdatatool ${KDE4_KDECORE_LIBS} ktexteditor kio \
kdeui )
install(TARGETS ktexteditor_kdatatool DESTINATION ${PLUGIN_INSTALL_DIR} )
Index: kate/plugins/insertfile/CMakeLists.txt
===================================================================
--- kate/plugins/insertfile/CMakeLists.txt (revision 821552)
+++ kate/plugins/insertfile/CMakeLists.txt (working copy)
@@ -6,7 +6,7 @@
kde4_add_plugin(ktexteditor_insertfile ${ktexteditor_insertfile_PART_SRCS})
-target_link_libraries(ktexteditor_insertfile ${KDE4_KDECORE_LIBS} ktexteditor )
+target_link_libraries(ktexteditor_insertfile ${KDE4_KDECORE_LIBS} ktexteditor kdeui \
kfile)
install(TARGETS ktexteditor_insertfile DESTINATION ${PLUGIN_INSTALL_DIR} )
Index: kate/plugins/wordcompletion/CMakeLists.txt
===================================================================
--- kate/plugins/wordcompletion/CMakeLists.txt (revision 821552)
+++ kate/plugins/wordcompletion/CMakeLists.txt (working copy)
@@ -5,7 +5,7 @@
kde4_add_plugin(ktexteditor_docwordcompletion \
${ktexteditor_docwordcompletion_PART_SRCS} )
-target_link_libraries(ktexteditor_docwordcompletion ${KDE4_KDECORE_LIBS} ktexteditor \
) +target_link_libraries(ktexteditor_docwordcompletion ${KDE4_KDECORE_LIBS} \
ktexteditor kio kdeui)
install(TARGETS ktexteditor_docwordcompletion DESTINATION ${PLUGIN_INSTALL_DIR} )
Index: kate/CMakeLists.txt
===================================================================
--- kate/CMakeLists.txt (revision 821552)
+++ kate/CMakeLists.txt (working copy)
@@ -146,12 +146,12 @@
kde4_add_plugin(katepart ${katepart_PART_SRCS})
# linking
-target_link_libraries(katepart ${KDE4_KDECORE_LIBS} kutils ktexteditor kde3support \
${QT_QTSCRIPT_LIBRARY}) +target_link_libraries(katepart ${KDE4_KDECORE_LIBS} kparts \
kutils ktexteditor kde3support ${QT_QTSCRIPT_LIBRARY})
if(KDE4_ENABLE_FINAL)
- macro_add_file_dependencies(${CMAKE_CURRENT_BINARY_DIR}/katepart_final_cpp.cpp )
+ macro_add_file_dependencies(${CMAKE_CURRENT_BINARY_DIR}/katepart_final_cpp.cpp )
else(KDE4_ENABLE_FINAL)
- macro_add_file_dependencies(${CMAKE_CURRENT_SOURCE_DIR}/script/katescript.cpp )
+ macro_add_file_dependencies(${CMAKE_CURRENT_SOURCE_DIR}/script/katescript.cpp )
endif(KDE4_ENABLE_FINAL)
# install the stuff
Index: kfile/CMakeLists.txt
===================================================================
--- kfile/CMakeLists.txt (revision 821552)
+++ kfile/CMakeLists.txt (working copy)
@@ -39,7 +39,10 @@
${KDE4_SOLID_LIBS}
)
-set_target_properties(kfile PROPERTIES VERSION ${GENERIC_LIB_VERSION} SOVERSION \
${GENERIC_LIB_SOVERSION} ) +set_target_properties(kfile PROPERTIES VERSION \
${GENERIC_LIB_VERSION} + SOVERSION \
${GENERIC_LIB_SOVERSION} + \
LINK_INTERFACE_LIBRARIES "kio;kdeui;kdecore") +
install(TARGETS kfile ${INSTALL_TARGETS_DEFAULT_ARGS})
install( FILES
Index: kross/core/CMakeLists.txt
===================================================================
--- kross/core/CMakeLists.txt (revision 821552)
+++ kross/core/CMakeLists.txt (working copy)
@@ -11,8 +11,11 @@
)
kde4_add_library(krosscore SHARED ${krosscore_LIB_SRCS})
-target_link_libraries(krosscore ${KDE4_KDECORE_LIBS} ${KDE4_KDEUI_LIBS} \
${QT_QTSCRIPT_LIBRARY})
-set_target_properties(krosscore PROPERTIES VERSION ${GENERIC_LIB_VERSION} SOVERSION \
${GENERIC_LIB_SOVERSION}) +target_link_libraries(krosscore ${KDE4_KDECORE_LIBS} \
${KDE4_KDEUI_LIBS} ${QT_QTSCRIPT_LIBRARY} ${QT_QTXML_LIBRARY}) \
+set_target_properties(krosscore PROPERTIES VERSION ${GENERIC_LIB_VERSION} + \
SOVERSION ${GENERIC_LIB_SOVERSION} + \
LINK_INTERFACE_LIBRARIES "kdecore;${QT_QTSCRIPT_LIBRARY};${QT_QTXML_LIBRARY}") +
install(TARGETS krosscore ${INSTALL_TARGETS_DEFAULT_ARGS})
install(FILES
Index: kross/ui/CMakeLists.txt
===================================================================
--- kross/ui/CMakeLists.txt (revision 821552)
+++ kross/ui/CMakeLists.txt (working copy)
@@ -15,7 +15,11 @@
kde4_add_library(krossui SHARED ${krossui_LIB_SRCS})
target_link_libraries(krossui krosscore ${KDE4_KDEUI_LIBS} ${KDE4_KPARTS_LIBS} \
${KDE4_KIO_LIBS})
-set_target_properties(krossui PROPERTIES VERSION ${GENERIC_LIB_VERSION} SOVERSION \
${GENERIC_LIB_SOVERSION}) +set_target_properties(krossui PROPERTIES VERSION \
${GENERIC_LIB_VERSION} + SOVERSION \
${GENERIC_LIB_SOVERSION} + \
LINK_INTERFACE_LIBRARIES "krosscore") +
+
install(TARGETS krossui ${INSTALL_TARGETS_DEFAULT_ARGS})
########### install files ###############
Index: kparts/CMakeLists.txt
===================================================================
--- kparts/CMakeLists.txt (revision 821552)
+++ kparts/CMakeLists.txt (working copy)
@@ -26,7 +26,11 @@
target_link_libraries(kparts ${KDE4_KDECORE_LIBS} kdeui kio)
-set_target_properties(kparts PROPERTIES VERSION ${GENERIC_LIB_VERSION} SOVERSION \
${GENERIC_LIB_SOVERSION} ) +set_target_properties(kparts PROPERTIES VERSION \
${GENERIC_LIB_VERSION} + SOVERSION \
${GENERIC_LIB_SOVERSION} + \
LINK_INTERFACE_LIBRARIES "kio;kdeui;kdecore") +
+
install(TARGETS kparts ${INSTALL_TARGETS_DEFAULT_ARGS})
########### install files ###############
Index: kded/CMakeLists.txt
===================================================================
--- kded/CMakeLists.txt (revision 821552)
+++ kded/CMakeLists.txt (working copy)
@@ -13,7 +13,7 @@
kde4_add_kdeinit_executable(kded4 ${kded_KDEINIT_SRCS})
-target_link_libraries(kdeinit_kded4 ${KDE4_KIO_LIBS} )
+target_link_libraries(kdeinit_kded4 ${KDE4_KIO_LIBS} ${X11_LIBRARIES})
install(TARGETS kdeinit_kded4 ${INSTALL_TARGETS_DEFAULT_ARGS})
Index: kioslave/file/CMakeLists.txt
===================================================================
--- kioslave/file/CMakeLists.txt (revision 821552)
+++ kioslave/file/CMakeLists.txt (working copy)
@@ -16,10 +16,15 @@
kde4_add_plugin(kio_file ${kio_file_PART_SRCS})
target_link_libraries(kio_file ${KDE4_KDECORE_LIBS} kio )
+
if (HAVE_VOLMGT AND CMAKE_SYSTEM_NAME MATCHES SunOS)
target_link_libraries(kio_file -lvolmgt)
endif (HAVE_VOLMGT AND CMAKE_SYSTEM_NAME MATCHES SunOS)
+if(ACL_FOUND)
+ target_link_libraries(kio_file ${ACL_LIBS})
+endif(ACL_FOUND)
+
install(TARGETS kio_file DESTINATION ${PLUGIN_INSTALL_DIR} )
Index: kioslave/http/kcookiejar/CMakeLists.txt
===================================================================
--- kioslave/http/kcookiejar/CMakeLists.txt (revision 821552)
+++ kioslave/http/kcookiejar/CMakeLists.txt (working copy)
@@ -40,13 +40,11 @@
qt4_add_dbus_adaptor( kded_kcookiejar_PART_SRCS org.kde.KCookieServer.xml \
kcookieserver.h KCookieServer )
-
-
qt4_add_dbus_adaptor( kcookiejar_SRCS org.kde.KCookieServer.xml kcookieserver.h \
KCookieServer )
kde4_add_plugin(kded_kcookiejar ${kded_kcookiejar_PART_SRCS})
-target_link_libraries(kded_kcookiejar ${KDE4_KIO_LIBS} ${QT_QT3SUPPORT_LIBRARY} )
+target_link_libraries(kded_kcookiejar ${KDE4_KIO_LIBS} ${QT_QT3SUPPORT_LIBRARY} \
${X11_LIBRARIES})
install(TARGETS kded_kcookiejar DESTINATION ${PLUGIN_INSTALL_DIR} )
Index: kioslave/http/CMakeLists.txt
===================================================================
--- kioslave/http/CMakeLists.txt (revision 821552)
+++ kioslave/http/CMakeLists.txt (working copy)
@@ -37,7 +37,7 @@
kde4_add_kdeinit_executable( kio_http_cache_cleaner NOGUI \
${kio_http_cache_cleaner_KDEINIT_SRCS})
-target_link_libraries(kdeinit_kio_http_cache_cleaner ${KDE4_KIO_LIBS} )
+target_link_libraries(kdeinit_kio_http_cache_cleaner ${KDE4_KIO_LIBS} \
${ZLIB_LIBRARY})
install(TARGETS kdeinit_kio_http_cache_cleaner ${INSTALL_TARGETS_DEFAULT_ARGS})
@@ -57,7 +57,7 @@
kde4_add_plugin(kio_http ${kio_http_PART_SRCS})
-target_link_libraries(kio_http ${KDE4_KIO_LIBS} kntlm )
+target_link_libraries(kio_http ${KDE4_KIO_LIBS} kntlm ${ZLIB_LIBRARY} )
if(GSSAPI_FOUND)
target_link_libraries(kio_http ${GSSAPI_LIBS} )
endif(GSSAPI_FOUND)
Index: kinit/CMakeLists.txt
===================================================================
--- kinit/CMakeLists.txt (revision 821552)
+++ kinit/CMakeLists.txt (working copy)
@@ -135,7 +135,7 @@
kde4_add_kdeinit_executable( klauncher NOGUI ${klauncher_KDEINIT_SRCS})
set_target_properties(kdeinit_klauncher PROPERTIES DEFINE_SYMBOL MAKE_KLAUNCHER)
-target_link_libraries(kdeinit_klauncher ${KDE4_KIO_LIBS} )
+target_link_libraries(kdeinit_klauncher ${KDE4_KIO_LIBS} ${X11_LIBRARIES})
install(TARGETS kdeinit_klauncher ${INSTALL_TARGETS_DEFAULT_ARGS})
Index: kio/CMakeLists.txt
===================================================================
--- kio/CMakeLists.txt (revision 821552)
+++ kio/CMakeLists.txt (working copy)
@@ -236,7 +236,7 @@
kde4_add_library(kio SHARED ${kio_LIB_SRCS})
-target_link_libraries(kio ${KDE4_KDEUI_LIBS} ${ZLIB_LIBRARY} \
${STRIGI_STREAMANALYZER_LIBRARY} ${STRIGI_STREAMS_LIBRARY} ${KDE4_SOLID_LIBS}) \
+target_link_libraries(kio ${KDE4_KDEUI_LIBS} ${ZLIB_LIBRARY} \
${STRIGI_STREAMANALYZER_LIBRARY} ${STRIGI_STREAMS_LIBRARY} ${KDE4_SOLID_LIBS} \
${QT_QTNETWORK_LIBRARY} ${QT_QTXML_LIBRARY} ${X11_LIBRARIES})
set(SYS_INOTIFY_H_FOUND 0)
@@ -259,8 +259,11 @@
target_link_libraries(kio ${X11_Xrender_LIB})
endif(X11_Xrender_FOUND)
-set_target_properties(kio PROPERTIES VERSION ${KDE_NON_GENERIC_LIB_VERSION} \
SOVERSION ${KDE_NON_GENERIC_LIB_SOVERSION} ) +set_target_properties(kio PROPERTIES \
VERSION ${KDE_NON_GENERIC_LIB_VERSION} + \
SOVERSION ${KDE_NON_GENERIC_LIB_SOVERSION} + \
LINK_INTERFACE_LIBRARIES "kdeui;kdecore;${QT_QTNETWORK_LIBRARY};${QT_QTXML_LIBRARY}") \
+
########### install files ###############
install(TARGETS kio ${INSTALL_TARGETS_DEFAULT_ARGS})
Index: kdeui/CMakeLists.txt
===================================================================
--- kdeui/CMakeLists.txt (revision 821552)
+++ kdeui/CMakeLists.txt (working copy)
@@ -315,7 +315,10 @@
target_link_libraries(kdeui ${X11_Xrender_LIB})
endif(X11_Xrender_FOUND)
-set_target_properties(kdeui PROPERTIES VERSION ${KDE_NON_GENERIC_LIB_VERSION} \
SOVERSION ${KDE_NON_GENERIC_LIB_SOVERSION} ) +set_target_properties(kdeui PROPERTIES \
VERSION ${KDE_NON_GENERIC_LIB_VERSION} + SOVERSION \
${KDE_NON_GENERIC_LIB_SOVERSION} + \
LINK_INTERFACE_LIBRARIES "kdecore;${QT_QTSVG_LIBRARY};${QT_QTGUI_LIBRARY}" + \
) install(TARGETS kdeui ${INSTALL_TARGETS_DEFAULT_ARGS})
########### install files ###############
@@ -548,7 +551,7 @@
endif ( Q_WS_QWS )
kde4_add_plugin( kded_globalaccel ${kded_globalaccel_SRCS} )
-target_link_libraries(kded_globalaccel ${KDE4_KDECORE_LIBS} ${KDE4_KDEUI_LIBS} )
+target_link_libraries(kded_globalaccel ${KDE4_KDECORE_LIBS} ${KDE4_KDEUI_LIBS} \
${X11_LIBRARIES})
install( TARGETS kded_globalaccel DESTINATION ${PLUGIN_INSTALL_DIR} )
Index: kutils/kemoticons/providers/adium/CMakeLists.txt
===================================================================
--- kutils/kemoticons/providers/adium/CMakeLists.txt (revision 821552)
+++ kutils/kemoticons/providers/adium/CMakeLists.txt (working copy)
@@ -5,7 +5,7 @@
kde4_add_plugin(emoticonstheme_adium ${adiumemoticons_SRCS})
-target_link_libraries(emoticonstheme_adium kutils ${KDE4_KDEUI_LIBS})
+target_link_libraries(emoticonstheme_adium kutils ${KDE4_KDEUI_LIBS} \
${QT_QTXML_LIBRARY})
########### install files ###############
Index: kutils/kemoticons/providers/kde/CMakeLists.txt
===================================================================
--- kutils/kemoticons/providers/kde/CMakeLists.txt (revision 821552)
+++ kutils/kemoticons/providers/kde/CMakeLists.txt (working copy)
@@ -5,7 +5,7 @@
kde4_add_plugin(emoticonstheme_kde ${kdeemoticons_SRCS})
-target_link_libraries(emoticonstheme_kde kutils ${KDE4_KDEUI_LIBS})
+target_link_libraries(emoticonstheme_kde kutils ${KDE4_KDEUI_LIBS} \
${QT_QTXML_LIBRARY})
########### install files ###############
Index: kutils/kemoticons/providers/xmpp/CMakeLists.txt
===================================================================
--- kutils/kemoticons/providers/xmpp/CMakeLists.txt (revision 821552)
+++ kutils/kemoticons/providers/xmpp/CMakeLists.txt (working copy)
@@ -5,7 +5,7 @@
kde4_add_plugin(emoticonstheme_xmpp ${xmppemoticons_SRCS})
-target_link_libraries(emoticonstheme_xmpp kutils ${KDE4_KDEUI_LIBS})
+target_link_libraries(emoticonstheme_xmpp kutils ${KDE4_KDEUI_LIBS} \
${QT_QTXML_LIBRARY})
########### install files ###############
Index: kdecore/CMakeLists.txt
===================================================================
--- kdecore/CMakeLists.txt (revision 821552)
+++ kdecore/CMakeLists.txt (working copy)
@@ -248,7 +248,8 @@
set_target_properties(kdecore PROPERTIES
VERSION ${KDE_NON_GENERIC_LIB_VERSION}
- SOVERSION ${KDE_NON_GENERIC_LIB_SOVERSION})
+ SOVERSION ${KDE_NON_GENERIC_LIB_SOVERSION}
+ LINK_INTERFACE_LIBRARIES \
"${QT_QTDBUS_LIBRARY};${QT_QTCORE_LIBRARY}")
install(TARGETS kdecore ${INSTALL_TARGETS_DEFAULT_ARGS})
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic