[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: KDE/kdelibs/cmake/modules
From:       Alexander Neundorf <neundorf () kde ! org>
Date:       2008-05-20 19:59:15
Message-ID: 200805202159.15525.neundorf () kde ! org
[Download RAW message or body]

On Tuesday 20 May 2008, Thiago Macieira wrote:
> On Tuesday 20 May 2008 16:59:40 Allen Winter wrote:
> > be extra careful about libICE and libSM prerequisites since many
> > distros have separate development packages for these.
> >
> > --- trunk/KDE/kdelibs/cmake/modules/FindX11.cmake #810371:810372
> > @@ -295,6 +295,14 @@
> >       SET(X11_SM_FOUND TRUE)
> >    ENDIF(X11_SM_LIB AND X11_SM_INCLUDE_PATH)
> >
> > +  IF(NOT X11_ICE_FOUND)
> > +    MESSAGE(FATAL_ERROR "\nThe X11 Inter-Client Exchange (ICE) Library
> > could not be found.\nCannot continue. Please install libICE.\n") +
> > ENDIF(NOT X11_ICE_FOUND)
> > +
> > +  IF(NOT X11_SM_FOUND)
> > +    MESSAGE(FATAL_ERROR "\nThe X11 Session Management (SM) Library could
> > not be found.\nCannot contineu. Please install libSM.\n") +  ENDIF(NOT
> > X11_SM_FOUND)
> > +
> >    # Deprecated variable for backwards compatibility with CMake 1.4
> >    IF (X11_X11_INCLUDE_PATH AND X11_LIBRARIES)
> >      SET(X11_FOUND 1)
>
> I don't think FindX11.cmake is the place to put this. It should be in the
> KDE code that requires X11 in the first place. In fact, it should be in the
> code that requires ICE and/or SM, since other parts of KDE may be just fine
> compiling with X11, but not those two.

Ok, I should have read all mails before starting to answer.
So, I agree with Thiago, 
As it is, it is an actual bug, because it fails without checking if X11 is 
REQUIRED.
Beside that, as Thiago says, it should be in the code which uses ICE and sm.

Alex
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]