From kde-buildsystem  Sat Jan 12 16:42:28 2008
From: Christian Ehrlicher <Ch.Ehrlicher () gmx ! de>
Date: Sat, 12 Jan 2008 16:42:28 +0000
To: kde-buildsystem
Subject: Getting rid of the LIB_INSTALL_DIR hack on windows
Message-Id: <4788EDF4.4050206 () gmx ! de>
X-MARC-Message: https://marc.info/?l=kde-buildsystem&m=120015619232743
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============1593820215=="

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--===============1593820215==
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enig9BA4E67A60BAB904FD7801E7"

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig9BA4E67A60BAB904FD7801E7
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hi,

I know we discussed this already, but I'm very unhappy with the current
solution.
The problem is (for all who don't remember) that we want to install the
shared libs into /bin on windows. When we install the shared libs into
/lib, we've to add an entry to the PATH env variable. Also it's not the
normal way to install shared libs in another location than the
executable - it would just confuse the user.

Because of this a hack for LIB_INSTALL_DIR was added:
set(LIB_INSTALL_DIR      "lib${LIB_SUFFIX}"
                    RUNTIME DESTINATION "bin"
                    LIBRARY DESTINATION "lib${LIB_SUFFIX}"
                    ARCHIVE DESTINATION "lib${LIB_SUFFIX}"  )

This works fine until someone uses LIB_INSTALL_DIR in another context -
e.g. to install additional files, see kdepimlibs/gpgme++:

install(
     FILES
     ${CMAKE_CURRENT_BINARY_DIR}/GpgmeppConfig.cmake
     ${CMAKE_CURRENT_BINARY_DIR}/GpgmeppLibraryDepends.cmake
     DESTINATION
     ${LIB_INSTALL_DIR}/gpgmepp )



Therefore I want to change all CMakeLists.txt from

install(TARGETS foo DESTINATION ${LIB_INSTALL_DIR} )

to

install(TARGETS foo RUNTIME DESTINATION ${BIN_IINSTALL_DIR}
                    LIBRARY DESTINATION ${LIB_INSTALL_DIR}
                    ARCHIVE DESTINATION ${LIB_INSTALL_DIR}
        )

An additional macro install_kde_library() would work as well.

I don't see a problem to add those three lines as it does not affect
linux/unix and when someone forgets to add them it doesn't hurt either -
we'll notice that something is wrong when we try to start an app on windo=
ws.
Leaving the macro as it is now just gives us weird cmake errors and
we've to find a hack to work around the usage of LIB_INSTALL_DIR in the
concerning cmake scripts.



Any objections?
Christian




--------------enig9BA4E67A60BAB904FD7801E7
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHiO33HAIuqbOiZ+kRAoqdAJ48MZ8pAkGdw70aZunWLDlWOW4hcwCaA5QF
aY3+Gn75R1ZoqyuHR6PnVTU=
=IbC3
-----END PGP SIGNATURE-----

--------------enig9BA4E67A60BAB904FD7801E7--

--===============1593820215==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem

--===============1593820215==--