[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: [PATCH] Add optional arguments to QT4_GENERATE_DBUS_INTERFACE
From:       Thomas McGuire <thomas.mcguire () gmx ! net>
Date:       2007-12-19 19:53:22
Message-ID: 200712192053.23690.thomas.mcguire () gmx ! net
[Download RAW message or body]

Hi,

On Wednesday 19 December 2007, Alexander Neundorf wrote:
> On Wednesday 19 December 2007, Thomas McGuire wrote:
> > Hi,
> >
> > the current QT4_GENERATE_DBUS_INTERFACE does not allow me to only extract
> > methods marked with Q_SCRIPTABLE. I need this for KMail, I don't want to
> > export each public slot.
> >
> > The attached patch simply uses an optional parameter to specify the
> > parameters for qdbuscpp2xml. For example, by passing -psm to the macro,
> > only scriptable methodes are exported.
> >
> > Is the patch OK? Any comments? Can I commit?
>
> It would be ok if there wouldn't be support for additional options since a
> few days ago in the cmake cvs version of FindQt4.cmake, which looks like
> this:
>
> QT4_ADD_RESOURCES(outfiles inputfile ... OPTIONS ...)
>
> So there you can add options as you want for the tool after the OPTIONS
> keyword.
> It seems we want that for our FindQt4.cmake too ?
Oh, I didn't know CVS had it already. In that case, my patch is not needed.
How are these things handled? Can it be backported to the KDE FindQt4.cmake 
until we require a higher version?

Regards,
Thomas
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]