[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    [PATCH] builds libs by default with full RPATH
From:       Alexander Neundorf <neundorf () kde ! org>
Date:       2007-12-16 9:34:25
Message-ID: 200712161034.25566.neundorf () kde ! org
[Download RAW message or body]

Hi,

attached you can find a small patch which changes the default value of the 
option KDE4_USE_ALWAYS_FULL_RPATH from OFF to ON.
A better name for that option would be "KDE_BUILD_LIBS_WITH_RPATH", then I 
wouldn't have to explain what it does.

Pros: libs should always have the correct RPATH
Cons: "make install" will take longer, since libs then also have to be 
relinked (as long as cmake without chrpath support is used)

Alex

P.S. actually I'm thinking about removing this option completely and build 
libs always with RPATH. People who don't like RPATH can still enable 
CMAKE_SKIP_RPATH to have no RPATH at all.
Comments ?

P.P.S. the change with the -Wl,--enable-new-dtags is not committed yet, 
right ? Are there reasons which speak against it ?

P.P.P.S. is it actually good enough to send this patch here or should it go to 
k-c-d, since we already had RC2 ?

["rpath.patch" (text/x-diff)]

Index: FindKDE4Internal.cmake
===================================================================
--- FindKDE4Internal.cmake	(revision 749013)
+++ FindKDE4Internal.cmake	(working copy)
@@ -709,7 +709,7 @@
 
 # also use /usr/local by default under UNIX, including Mac OS X
 if (UNIX)
-   option(KDE4_USE_ALWAYS_FULL_RPATH "If set to TRUE, also libs and plugins will be \
linked with the full RPATH, which will usually make them work better, but make \
install will take longer." OFF) +   option(KDE4_USE_ALWAYS_FULL_RPATH "If set to \
TRUE, also libs and plugins will be linked with the full RPATH, which will usually \
make them work better, but make install will take longer." ON)  
    set( _KDE4_PLATFORM_INCLUDE_DIRS)
 



_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem


[prev in list] [next in list] [prev in thread] [next in thread]