[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    Re: kcheckpass setuid
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2007-10-26 16:40:44
Message-ID: 20071026164044.GC6810 () ugly ! local
[Download RAW message or body]

On Fri, Oct 26, 2007 at 06:30:52PM +0200, Alexander Neundorf wrote:
> On Friday 26 October 2007, Oswald Buddenhagen wrote:
> > the root of the evil is this line in kcheckpass's cmakelists:
> >
> > install(TARGETS kcheckpass DESTINATION ${BIN_INSTALL_DIR} PERMISSIONS
> > SETUID OWNER_EXECUTE OWNER_WRITE OWNER_READ GROUP_EXECUTE GROUP_READ
> > WORLD_EXECUTE WORLD_READ)
> >
> > cmake fails to chown - of course - but does not abort and simply goes on
> > with the chmod to setuid. of course, the result is complete nonsense.
> 
> I think you are slightly wrong here.
> CMake doesn't *fail* to chown, it doesn't chown *at all*.
>
oh, right, i'm an idiot. :}

> -file a feature request at www.cmake.org/Bug
>
yup

> -add a post install command which does the chown (chmod is already done)
> 
i'll simply commit my path. it does The Right Thing (TM).

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Chaos, panic, and disorder - my work here is done.
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
[prev in list] [next in list] [prev in thread] [next in thread]