[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    There can be only one! (global.h)
From:       thiago () kde ! org (Thiago Macieira)
Date:       2006-03-06 21:09:17
Message-ID: 200603062209.18147.thiago () kde ! org
[Download RAW message or body]

Alexander Neundorf wrote:
>On Monday 06 March 2006 14:51, David Faure wrote:
>> On Monday 06 March 2006 14:00, Peter K?mmel wrote:
>> > Is kio/global.h that useful that it will be included without any
>> > other headers of kio? I just don't know.
>>
>> Yes. KIO::encodeFileName, KIO::decodeFileName, KIO::convertSize,
>> KIO::findCacheMountPoint etc.
>>
>> > > So what's the problem with declaring the problem fixed and moving
>> > > on? ;-))
>> >
>> > I've the impression it's not a good fix.
>>
>> kio/global.h has been around for more than 5 years and never created
>> trouble. The problem came from some wrong buildsystem file.
>
>Yes, but still it's a trap which one can run into. I'd also vote for
> making this really safe by renaming the headers to unique names.

Where possible, yes, simple names should be avoided.

base.h, client.h, server.h, etc.
That kind of name should be avoided.

However, properly prefixing it with a directory name should be safe:
myapp/base.h, for instance

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

1. On frumscafte, hwonne time_t w?s n?ht, se scieppend ?one circolwyrde 
wundorcr?ftl?ge cennede and seo eor?e w?s idel and hit w?s g?d.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20060307/13125de6/attachment-0001.pgp 

[prev in list] [next in list] [prev in thread] [next in thread]