[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: mingw status
From: ralf.habacker () freenet ! de (Ralf Habacker)
Date: 2006-03-05 13:00:44
Message-ID: 440AE0FC.5090206 () freenet ! de
[Download RAW message or body]
Peter K?mmel schrieb:
> Ralf Habacker wrote:
>
>>> If you see no problem, I will check this in.
>>>
>
> The patch by itself is ok for mingw, it now compiles fine with it.
>
> But it breaks compiling with msvc,
>
> error C2487: 'KJS::UString::{ctor}' :
> member of dll interface class may not be declared with dll interface
>
> (seems msvc links the functions static), so you should enable the
> patch only for mingw, e.g.:
>
> # elif (defined(_WIN32) || defined(_WIN64)) && defined(__GNUC__)
>
>
> Also the cmake build process is broken by this patch because
> of the including of the wrong global.h in ustring.h.
> (I've tested it by temporary moving the code from kjs/global.h
> to ustring.h. There are really too much global.h files! )
>
wouldn't it help to use
#include "kjs/global.h"
in ustring.h for now ? Does this work for msvc ?
> So you could wait with committing your patch until the cmake build
> process is fixed or force fixing by committing. ;)
>
>
Ralf
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic