[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-buildsystem
Subject: dcop/iceauth msvc fix
From: Ch.Ehrlicher () gmx ! de (Christian Ehrlicher)
Date: 2006-02-23 5:54:40
Message-ID: 43FD4E20.30606 () gmx ! de
[Download RAW message or body]
Michael Dr?ing schrieb:
> Hi,
>
> OK, now that I have DCOPserver up and running, I fixed a small TODO in
> dcopserver_shutdown, which prevented it from running.
> Here's the patch:
>
> Index: dcopserver_shutdown.c
> ===================================================================
> --- dcopserver_shutdown.c (revision 512583)
> +++ dcopserver_shutdown.c (working copy)
> @@ -90,8 +90,11 @@
> int n;
>
> n = max_length;
> - /* TODO: (rh) add win32 home dir */
> +#ifdef _WIN32
> + home_dir = getenv("USERPROFILE");
> +#else
> home_dir = getenv("HOME");
> +#endif
> strncpy(dcop_file, home_dir, n);
> dcop_file[ n - 1 ] = '\0';
> n -= strlen(home_dir);
>
>
> I suppose this is for W2k/NT only, I don't know (and, honestly, I don't
> really care ;-) if Win9x also has that variable defined.....
Do you really think this is a good idea? I mean - do you really want to
replace 'HOME' with 'USERPROFILE' in every kde app? For this we used
kde_bootstrap() which currently doesn't work because we don't want to
use the kdemain()-hack anymore...
I think it's a better idea to work on compiler/linker errors or help
porting to Qt4 rather than try to get dcop working - afaik it gets
removed in kde4.
Christian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20060223/5025fab7/attachment.pgp
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic