[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-buildsystem
Subject:    [Patch] fix compile kdeui with msvc
From:       ralf.habacker () freenet ! de (Ralf Habacker)
Date:       2005-11-01 7:10:24
Message-ID: 200511010810.24609.ralf.habacker () freenet ! de
[Download RAW message or body]

Am Montag, 31. Oktober 2005 15:47 schrieb David Faure:
> On Monday 31 October 2005 15:27, Ralf Habacker wrote:
> > Append is a patch for this, does anyhave see any problem  ?
>
> CFLAGS missing?
>
> > One question is if this should be activated by default ?
> >
> > Index: generic.py
> > ===================================================================
> > --- generic.py  (revision 476063)
> > +++ generic.py  (working copy)
> > @@ -285,6 +285,9 @@
> >                 if self.libprefix != '' and
> > self.target[:len(self.libprefix)] == self.libprefix:
> >                         self.target = self.target[len(self.libprefix):]
> >
> > +               if self.type in ['shlib','kioslave','module']:
> > +                       self.env.AppendUnique( CCFLAGS =
> > ['-DMAKE_'+self.target.upper()+'_LIB'] )
>
> Looks good to me. I see no reason against having this activated by default,
> it will be useful in all svn modules.

also for non windows targets ? 

Ralf 

[prev in list] [next in list] [prev in thread] [next in thread]