[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice
Subject:    Bug#19794: kformula crashes when deleting document contents
From:       Toshitaka Fujioka <tositaka () soft ! kusa ! ac ! jp>
Date:       2001-02-05 11:11:39
[Download RAW message or body]

Hello.

diegofjt@yahoo.com wrote:

> Package: koffice
> Version: 2.1 Beta 2
> Severity: crash
> 
> This bug is related to kformula 0.2. When I create a new
> document, type some characters and then delete all of
> them at once (using the delete key only; I don't know if
> this happens when selecting all and deleting it at once),
> kformula crashes with a SIGSEGV signal. Not a very important
> bug, but it can be disturbing.
> 
> Diego
> 

I think that I can fixes this bug when you apply the patch which
I attached. (CVS of 02/02)

Please try to use. :-)
If this patch is wrong, please advise.



["koffice-kformula-bugfix-20010205.diff" (text/plain)]

diff -ur koffice.org/kformula/kformula_doc.cc koffice/kformula/kformula_doc.cc
--- koffice.org/kformula/kformula_doc.cc	Fri Feb  2 16:34:22 2001
+++ koffice/kformula/kformula_doc.cc	Mon Feb  5 19:49:22 2001
@@ -654,9 +654,11 @@
         BasicElement *prev;
         newActive=currentElement()->getNext();
         prev=currentElement()->getPrev();
-        currentElement()->deleteElement();
         if(prev!=0)
-          prev->check();
+          {
+            currentElement()->deleteElement();
+            prev->check();
+          }
         setActiveElement(newActive);
 
       }


[prev in list] [next in list] [prev in thread] [next in thread]